ITP_GLASGOW_APR | HANNA_MYKYTIUK | MODULE_DATA_GROUPS | SPRINT_3 #498
Conversation
|
Can you create separate branch for each project? You can create a new branch for each projects and then copy/paste your files from each project in this branch to their respective branches. After that, you can submit separate PR for each project in the Sprint-3 folder. |
cjyuan
added
👀 Review Git
There was a problem hiding this comment.
I only reviewed "Alarm Clock" and "Quote Generator" so you can start making necessary changes.
Step 3 asks for separate PR links for these two projects. So please create separate branches and PRs for these two projects, and make your changes in the new branches.
| function setAlarm() {} | ||
| function setAlarm() { | ||
| let heading = document.getElementById("timeRemaining"); | ||
| let seconds = document.getElementById("alarmSet").value; |
There was a problem hiding this comment.
Some unusual input values that can make your app behave abnormally can still pass this check. Can you add code to sanitise them?
There was a problem hiding this comment.
Code works fine if a user only clicks the "Set Alarm" button once.
However, if the user enters a time and then clicks the "Set Alarm" button multiple times, the countdown clock will not display properly.
Can you fix the issue?
| let quoteObj = pickFromArray(quotes); | ||
| let quote = quoteObj.quote; | ||
| let author = quoteObj.author; |
There was a problem hiding this comment.
Can consider using object destructuring to simplify these three statements into one.
cjyuan
added
Reviewed
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.