ITP_JAN25 | KATARZYNA_KAZIMIERCZUK | MODULE_DATA_GROUPS | SPRINT2 #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katarzynakaz
added
Needs Review
cjyuan
reviewed
Apr 18, 2025
There was a problem hiding this comment.
Code is generally good. I have left you some suggestions.
This branch should not contains modified files in the Sprint-1 folder. Can you fix the branch? (One way to fix the branch is to replace the files in Sprint-1 folder by the same files in your main branch).
cjyuan
added
Reviewed
katarzynakaz
added
the
Complete
katarzynakaz
added
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Briefly explain your PR.
Finished Sprint 2.
Questions
No questions.