Skip to content

ITP_LONDON | PRISCILLA_EMEBO | Module-Data-Groups | Todo-list #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions Sprint-3/todo-list/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,13 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Title here</title>
<title>Todo List</title>
<link rel="stylesheet" href="style.css" />
<!-- Font Awesome for icons -->
<link
rel="stylesheet"
href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.4.0/css/all.min.css"
/>
</head>
<body>
<form>
Expand All @@ -13,15 +18,14 @@
</div>
<div>
<button type="submit">Add Todo</button>
<button
type="button"
id="remove-all-completed"
class="btn btn-primary mb-3"
>
<button type="button" id="remove-all-completed">
Remove all completed
</button>
</div>
</form>

<ul id="todo-list" class="list-group"></ul>

<script src="script.js"></script>
</body>
</html>
72 changes: 58 additions & 14 deletions Sprint-3/todo-list/script.js
Original file line number Diff line number Diff line change
@@ -1,25 +1,69 @@
function populateTodoList(todos) {
let list = document.getElementById("todo-list");
// Write your code to create todo list elements with completed and delete buttons here, all todos should display inside the "todo-list" element.
}

// These are the same todos that currently display in the HTML
// You will want to remove the ones in the current HTML after you have created them using JavaScript
// GLOBAL todos array
let todos = [
{ task: "Wash the dishes", completed: false },
{ task: "Do the shopping", completed: false },
];

function populateTodoList(todos) {
const list = document.getElementById("todo-list");
list.innerHTML = ""; // Clear the list first

todos.forEach((todo) => {
const li = document.createElement("li");
li.className =
"list-group-item d-flex justify-content-between align-items-center";
li.textContent = todo.task;

if (todo.completed) {
li.style.textDecoration = "line-through";
}

const span = document.createElement("span");
span.className = "badge bg-primary rounded-pill";

const checkIcon = document.createElement("i");
checkIcon.className = "fa fa-check";
checkIcon.style.cursor = "pointer";
checkIcon.addEventListener("click", () => {
todo.completed = !todo.completed;
li.style.textDecoration = todo.completed ? "line-through" : "none";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could just call populateTodoList() to update the view (to avoid maintaining two sets of code to change view).

});

const trashIcon = document.createElement("i");
trashIcon.className = "fa fa-trash ms-2";
trashIcon.style.cursor = "pointer";
trashIcon.addEventListener("click", () => {
todos.splice(todos.indexOf(todo), 1);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better performance (i.e., without the need to search for todo in the array), we could make available the index of the current todo at line 11 as

   todos.forEach((todo, index) => {

populateTodoList(todos);
});

span.appendChild(checkIcon);
span.appendChild(trashIcon);
li.appendChild(span);
list.appendChild(li);
});
}

populateTodoList(todos);

// This function will take the value of the input field and add it as a new todo to the bottom of the todo list. These new todos will need the completed and delete buttons adding like normal.
// Add new todo
function addNewTodo(event) {
// The code below prevents the page from refreshing when we click the 'Add Todo' button.
event.preventDefault();
// Write your code here... and remember to reset the input field to be blank after creating a todo!
const input = document.querySelector("input[type='text']");
const task = input.value.trim();
if (task !== "") {
todos.push({ task, completed: false });
input.value = "";
populateTodoList(todos);
}
}

// Advanced challenge: Write a fucntion that checks the todos in the todo list and deletes the completed ones (we can check which ones are completed by seeing if they have the line-through styling applied or not).
function deleteAllCompletedTodos() {
// Write your code here...
}
document.querySelector("form").addEventListener("submit", addNewTodo);

// Remove all completed
document
.getElementById("remove-all-completed")
.addEventListener("click", () => {
todos = todos.filter((todo) => !todo.completed);
populateTodoList(todos);
});