generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 93
ITP_LONDON | PRISCILLA_EMEBO | Module-Data-Groups | Todo-list #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Priscilla-EM
wants to merge
2
commits into
CodeYourFuture:main
Choose a base branch
from
Priscilla-EM:Todo--list
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,69 @@ | ||
function populateTodoList(todos) { | ||
let list = document.getElementById("todo-list"); | ||
// Write your code to create todo list elements with completed and delete buttons here, all todos should display inside the "todo-list" element. | ||
} | ||
|
||
// These are the same todos that currently display in the HTML | ||
// You will want to remove the ones in the current HTML after you have created them using JavaScript | ||
// GLOBAL todos array | ||
let todos = [ | ||
{ task: "Wash the dishes", completed: false }, | ||
{ task: "Do the shopping", completed: false }, | ||
]; | ||
|
||
function populateTodoList(todos) { | ||
const list = document.getElementById("todo-list"); | ||
list.innerHTML = ""; // Clear the list first | ||
|
||
todos.forEach((todo) => { | ||
const li = document.createElement("li"); | ||
li.className = | ||
"list-group-item d-flex justify-content-between align-items-center"; | ||
li.textContent = todo.task; | ||
|
||
if (todo.completed) { | ||
li.style.textDecoration = "line-through"; | ||
} | ||
|
||
const span = document.createElement("span"); | ||
span.className = "badge bg-primary rounded-pill"; | ||
|
||
const checkIcon = document.createElement("i"); | ||
checkIcon.className = "fa fa-check"; | ||
checkIcon.style.cursor = "pointer"; | ||
checkIcon.addEventListener("click", () => { | ||
todo.completed = !todo.completed; | ||
li.style.textDecoration = todo.completed ? "line-through" : "none"; | ||
}); | ||
|
||
const trashIcon = document.createElement("i"); | ||
trashIcon.className = "fa fa-trash ms-2"; | ||
trashIcon.style.cursor = "pointer"; | ||
trashIcon.addEventListener("click", () => { | ||
todos.splice(todos.indexOf(todo), 1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For better performance (i.e., without the need to search for
|
||
populateTodoList(todos); | ||
}); | ||
|
||
span.appendChild(checkIcon); | ||
span.appendChild(trashIcon); | ||
li.appendChild(span); | ||
list.appendChild(li); | ||
}); | ||
} | ||
|
||
populateTodoList(todos); | ||
|
||
// This function will take the value of the input field and add it as a new todo to the bottom of the todo list. These new todos will need the completed and delete buttons adding like normal. | ||
// Add new todo | ||
function addNewTodo(event) { | ||
// The code below prevents the page from refreshing when we click the 'Add Todo' button. | ||
event.preventDefault(); | ||
// Write your code here... and remember to reset the input field to be blank after creating a todo! | ||
const input = document.querySelector("input[type='text']"); | ||
const task = input.value.trim(); | ||
if (task !== "") { | ||
todos.push({ task, completed: false }); | ||
input.value = ""; | ||
populateTodoList(todos); | ||
} | ||
} | ||
|
||
// Advanced challenge: Write a fucntion that checks the todos in the todo list and deletes the completed ones (we can check which ones are completed by seeing if they have the line-through styling applied or not). | ||
function deleteAllCompletedTodos() { | ||
// Write your code here... | ||
} | ||
document.querySelector("form").addEventListener("submit", addNewTodo); | ||
|
||
// Remove all completed | ||
document | ||
.getElementById("remove-all-completed") | ||
.addEventListener("click", () => { | ||
todos = todos.filter((todo) => !todo.completed); | ||
populateTodoList(todos); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could just call
populateTodoList()
to update the view (to avoid maintaining two sets of code to change view).