Skip to content

ITP -Northwest- JAN 2025 | Jan Lo | Module-Data groups | Quote-Generator | WEEK 8 #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ITP -Northwest- JAN 2025 | Jan Lo | Module-Data groups | Quote-Generator | WEEK 8 #512

wants to merge 2 commits into from

Conversation

JanLlw
Copy link

@JanLlw JanLlw commented Apr 21, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@JanLlw JanLlw added the Needs Review Participant to add when requesting review label Apr 21, 2025
cjyuan
cjyuan reviewed Apr 21, 2025
View reviewed changes
Copy link

@cjyuan cjyuan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

You missed updating index.html according to an instruction in readme.md.

Feel free to mark this as "Complete" when you have made the changes.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Apr 21, 2025
@JanLlw JanLlw added the Needs Review Participant to add when requesting review label Apr 21, 2025
@cjyuan
Copy link

cjyuan commented Apr 22, 2025

You can add the "Complete" label.

@cjyuan cjyuan removed the Needs Review Participant to add when requesting review label Apr 22, 2025
@JanLlw JanLlw added Complete Participant to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JanLlw @cjyuan