Skip to content

ITP-Jan | NW | Jovy So | Module-Data-Groups | AlarmClockApp #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ITP-Jan | NW | Jovy So | Module-Data-Groups | AlarmClockApp #513

wants to merge 2 commits into from

Conversation

jovyso
Copy link

@jovyso jovyso commented Apr 21, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

I have finished the alarmclock app function and changed the style for the app.

Questions

Ask any questions you have for your reviewer.

@jovyso jovyso added the Needs Review Participant to add when requesting review label Apr 21, 2025
cjyuan
cjyuan reviewed Apr 22, 2025
View reviewed changes
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Feel free to mark this as "Complete" after you make the necessary changes.

Sprint-3/alarmclock/alarmclock.js
Comment on lines +23 to +25
updateTitle();
} else {
updateTitle();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can factor the function call updateTitle() out from the if-else block.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Apr 22, 2025
@jovyso jovyso added Complete Participant to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jovyso @cjyuan