Skip to content

NW7 | Sue Mohamadi | Module-Data-Groups Sprint-2 | week 2 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

NW7 | Sue Mohamadi | Module-Data-Groups Sprint-2 | week 2 #94

wants to merge 25 commits into from

Conversation

SueMsOl
Copy link

@SueMsOl SueMsOl commented Nov 29, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

SueMsOl added 25 commits November 12, 2024 18:33
@SueMsOl
moved mean.test.js to prep
8241878
@SueMsOl
created prep directory and installed jest dev dependency
f31523d
@SueMsOl
wrote and tested calculateMean()
c593db4
@SueMsOl
wrote and tested 2 different calculateMedian() versions
ab9c480
@SueMsOl
created a new file median.js
e59b150
@SueMsOl
declared and tested functions in mean.js and median.js
dbf8bb5
@SueMsOl
array-mutation.js file created
0c587f4
@SueMsOl
updated all functions to avoid array mutation
7fceec0
@SueMsOl
updated all functions to avoid array mutation
7ef108c
@SueMsOl
fixed median.js implementation error
f6c5241
@SueMsOl
wrote dedupe() function but dedupe.test.js does not work (CYF solutio…
690a612 
…n file also fails and outputs error in terminal)
@SueMsOl
wrote and tested findMax()
4f09cb7
@SueMsOl
wrote and tested sum()
984a6b5
@SueMsOl
refactored and tested includes()
87023c0
@SueMsOl
wrote and tested dedupe()
c613c89
@SueMsOl
wrote and tested code in solution.js
c3e1bcd
@SueMsOl
wrote 6 different versions of parseQueryString and tested the functio…
0c80690 
…n using jest and node frameworks.
@SueMsOl
finished debug
ce9ce31
@SueMsOl
implement dir functions written and tested
86d02a4
@SueMsOl
wrote and tested tally function
72a6a40
@SueMsOl
wrote and tested tally function
e8090f5
@SueMsOl
fixed and tested invert function
8f6a23d
@SueMsOl
wrote,tested and fixed functions in stretch directory
466ea0b
@SueMsOl
wrote,tested and fixed functions in stretch directory
82f1871
@SueMsOl
mode.js studied and tested
ad9e146
@SueMsOl SueMsOl added the Needs Review Participant to add when requesting review label Nov 30, 2024
@cjyuan
Copy link
Contributor

cjyuan commented Dec 11, 2024

I expected only modified files in the Sprint-2 folder (since this is a Sprint-2 PR), but there are modified files in the Sprint-1 folder.

Any chance you can rebase your current branch onto main?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review labels Dec 11, 2024
@cjyuan cjyuan added 👀 Review Git Changes requested to do with Git Needs Review Participant to add when requesting review labels Dec 11, 2024
@ellietms
Copy link
Member

Hi @SueMsOl , THis PR is waiting for you to address comments and answer questions.

@illicitonion illicitonion removed the Needs Review Participant to add when requesting review label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
👀 Review Git Changes requested to do with Git
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SueMsOl @cjyuan @ellietms @illicitonion