Skip to content

NW7 | Sue Mohamadi | Module-Data-Groups Sprint-2 | week 2 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

SueMsOl
Copy link

@SueMsOl SueMsOl commented Nov 29, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@SueMsOl SueMsOl added the Needs Review Participant to add when requesting review label Nov 30, 2024
@cjyuan
Copy link
Contributor

cjyuan commented Dec 11, 2024

I expected only modified files in the Sprint-2 folder (since this is a Sprint-2 PR), but there are modified files in the Sprint-1 folder.

Any chance you can rebase your current branch onto main?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review labels Dec 11, 2024
@cjyuan cjyuan added 👀 Review Git Changes requested to do with Git Needs Review Participant to add when requesting review labels Dec 11, 2024
@ellietms
Copy link
Member

Hi @SueMsOl , THis PR is waiting for you to address comments and answer questions.

@illicitonion illicitonion removed the Needs Review Participant to add when requesting review label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Review Git Changes requested to do with Git
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants