Skip to content

LON_ITP_JAN_25 | GENET HAILE _ MODULE_ONBOARDING_FORM _CONTROL | WEEK 3 SPRINT 2 #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

genethaile12
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Feb 8, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 9cb1456
🔍 Latest deploy log https://app.netlify.com/sites/cyf-onboarding-module/deploys/67a762b2b667340008f8cd04
😎 Deploy Preview https://deploy-preview-254--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 84 (🔴 down 2 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@genethaile12
Copy link
Author

@halilibrahimcelik can you please review my work.

@halilibrahimcelik halilibrahimcelik self-requested a review February 8, 2025 14:24
@halilibrahimcelik halilibrahimcelik added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 8, 2025
Copy link

@halilibrahimcelik halilibrahimcelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done you met all requirements stated in readme file. Also you can learn more about input types from this link https://www.w3schools.com/html/html_form_input_types.asp

@halilibrahimcelik halilibrahimcelik added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants