JAN25|SARAAMIRI|Module-Onboarding|week2 #264
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
day-lee
added
Review in progress
Form-Controls/index.html
Outdated
|
|
||
| <!--Customer's Name --> | ||
| <label for="name">What is your name?</label> | ||
| <input type="text" id="name" name="name" required minlength="2" placeholder="Enter your full name"> |
There was a problem hiding this comment.
Good job! Your code is easy to read and looks good overall.
It seems the name input accepts numbers as well. Can you think of a pattern attribute that only accepts a text string of two characters or more?
There was a problem hiding this comment.
thank you for your reviewing ,for block number and the name input only accept text string two or more character we can use this pattern: What is your name?
There was a problem hiding this comment.
There is a pattern attribute in the input type. It take a regex. Can you think of a regex pattern for a text string of two characters or more? pattern="regex"
|
|
||
| <form action="" method="POST"> | ||
| <h1>T-Shirt Order Form</h1> | ||
|
|
There was a problem hiding this comment.
The form would look more organised if it were grouped together. Can you add tags for better semantics and structure?
There was a problem hiding this comment.
thank you for reviewing my code here i need to use
and to group related field .
day-lee
added
Reviewed
saraamiiri
added
the
Complete
day-lee
added
Reviewed
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.