Skip to content

London-ITPJan| Rawan_Almutairi| wireframe| week1 #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Rawan-Al0-0
Copy link

@Rawan-Al0-0 Rawan-Al0-0 commented Feb 21, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 8c603d8
🔍 Latest deploy log https://app.netlify.com/sites/cyf-onboarding-module/deploys/67b8b958ffd8dc000826cde2
😎 Deploy Preview https://deploy-preview-272--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 90 (🟢 up 4 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@cjyuan cjyuan added the Needs Review Participant to add when requesting review label Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay. One thing i noticed is that your footer is not fixed to the bottom of the viewport, going by the requirements of the task, it is supposed to be fixed at the bottom of the viewport. Good job!

@A-O-Emmanuel A-O-Emmanuel added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Needs Review Participant to add when requesting review labels Feb 26, 2025
@Rawan-Al0-0 Rawan-Al0-0 closed this by deleting the head repository May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants