ITP-May-25|NW | Rahwa Zeslus| MODULE-ONBOARDING-WIREFRAME | Week1

[RahwaZeslusHaile]

ITP-May-25|NW | Rahwa Zeslus| MODULE-ONBOARDING-WIREFRAME | Week1

Self checklist

• [ x] I have committed my files one by one, on purpose, and for a reason
• [ x] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• [ x] I have tested my changes
• My changes follow the style guide
• [ x] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

• This PR implements a responsive and semantic wireframe design using HTML and CSS.
• The layout adapts to different screen sizes, and the structure follows semantic HTML5 standards for better accessibility and readability
• The page also scores 100 in Performance on Lighthouse, ensuring fast loading and optimized rendering.

Questions

kindly ask for your review

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	d24386a
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-onboarding-module/deploys/681b3a9b92fbef000835cffd
😎 Deploy Preview	https://deploy-preview-283--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 91 (🟢 up 5 from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[jenny-alexander]

A few other items I noticed:

1. The html page structure was a bit confusing to read through as I couldn't figure out the relationship between the <section> and the <article> tags. It seems that all 3 articles have equal importance (even though the top article takes up more space on the page). Since all 3 articles have equal importance, can you think of a better way to structure your page? Having a parent <article> with child <sections> for each article might be a good approach to try.
   https://www.w3schools.com/html/html5_semantic_elements.asp

2. Can you change the name of the PR to follow CYF naming standards? Like this:
   COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK

3. When checking off items in the self-checklist, use a 'x' in the checkbox instead. 🙂

[RahwaZeslusHaile]

Thank you @jenny-alexander for your feedback! I've made the changes you suggested and updated the project accordingly. Let me know if there’s anything else to improve! 😊

[jenny-alexander]

Good job!

I approved the PR. One last thing you didn't fix and you should make sure you do it for next time: use an 'x' in the checklist.

Read about it here: https://www.w3schools.io/file/markdown-checkbox-github/