Skip to content

ZA | ITP-MAY-2025 | OBERT TILIMANDZI | WIREFRAME | WEEK 1 #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

ZA | ITP-MAY-2025 | OBERT TILIMANDZI | WIREFRAME | WEEK 1 #549

wants to merge 13 commits into from

Conversation

obstie
Copy link

@obstie obstie commented May 17, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@netlify Netlify
Copy link

netlify bot commented May 17, 2025 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit fb42e69
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6842c1c2c359ff0009a539de
😎 Deploy Preview https://deploy-preview-549--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 86 (🔴 down 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 83 (🔴 down 3 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@obstie obstie requested review from jenny-alexander, shieldo and SallyMcGrath and removed request for shieldo May 18, 2025 06:21
@Waldo-Strydom
Copy link

Your css and imgs are not loading. Please check your src's and href.

@Waldo-Strydom Waldo-Strydom added 👀 Review Git Changes requested to do with Git 👀 Review Requirements Changes requested to meet requirements labels May 20, 2025
@obstie
Copy link
Author

obstie commented May 20, 2025 •
edited
Loading

CSS in now working and the images are also loading

@obstie obstie added the Needs Review Participant to add when requesting review label May 20, 2025
@Waldo-Strydom
Copy link

well done

@Waldo-Strydom Waldo-Strydom added Reviewed Volunteer to add when completing a review Complete Volunteer to add when work is complete and review comments have been addressed and removed 👀 Review Git Changes requested to do with Git 👀 Review Requirements Changes requested to meet requirements Needs Review Participant to add when requesting review labels May 21, 2025
obstie

This comment was marked as duplicate.

Sign in to view

obstie
obstie commented Jun 6, 2025
View reviewed changes
Copy link
Author

@obstie obstie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated my html

@Rashaad-Ebrahim Rashaad-Ebrahim mentioned this pull request Jun 6, 2025
Open
@obstie obstie mentioned this pull request Jun 6, 2025
Open
@cjyuan cjyuan mentioned this pull request Jun 6, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenny-alexander jenny-alexander Awaiting requested review from jenny-alexander

@SallyMcGrath SallyMcGrath Awaiting requested review from SallyMcGrath

@shieldo shieldo Awaiting requested review from shieldo

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obstie @Waldo-Strydom