Skip to content

London | May-2025 | Hendrine Zeraua| Wireframe #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rarityXtreme
Copy link

@rarityXtreme rarityXtreme commented May 19, 2025

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • I My changes follow the style guide
  • I My changes meet the requirements
    of this task

Changelist

  • This PR adds a new wireframe webpage that demonstrates the structure of a well-organized HTML document using
    semantic elements. It includes:
  • A header with a title and description.
  • Three unique article elements inside main, each with an image, heading, paragraph, and link.
  • A fixed footer at the bottom of the page.
  • External CSS for styling with improved contrast and accessibility.

Questions
No questions at this time.
.

Copy link

netlify bot commented May 19, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 6981afb
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/683dacd58e8e7800083e8a73
😎 Deploy Preview https://deploy-preview-562--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@rarityXtreme rarityXtreme added the Needs Review Participant to add when requesting review label May 19, 2025
@rarityXtreme rarityXtreme changed the title Add wireframe HTML and CSS files London | May-2025 | Hendrine Zeraua| Wireframe May 19, 2025
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels May 27, 2025
@jenny-alexander jenny-alexander self-requested a review May 27, 2025 03:45
@jenny-alexander
Copy link

@rarityXtreme - The information you provided on your webpage is great. Your page title, page description and footer are styled according to the wireframe. 👍

However, the main content of the page needs to be styled as close to the wireframe as possible. 👀 Notice how the main content has an article that takes up a large portion of the page (centered) and then the two other articles are centered underneath the first article?

  • Try your best to style it like this:
    Screenshot 2025-05-26 at 10 54 57 PM

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review 👀 Review Requirements Changes requested to meet requirements and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 27, 2025
@rarityXtreme rarityXtreme added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 28, 2025
Copy link

@jenny-alexander jenny-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking much closer to the wirefreame now. 👍

I think you can still get it closer to the exercise requirements.

  • the width of the 2 bottom articles should span the same width as the top article. Currently, your bottom two articles are spanning wider than the top article.
  • The short description underneath the page title is a bit too wide. Can you shorten your description a bit?

@rarityXtreme rarityXtreme added Needs Review Participant to add when requesting review and removed 👀 Review Requirements Changes requested to meet requirements labels Jun 2, 2025
@jenny-alexander jenny-alexander added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 2, 2025
@rarityXtreme
Copy link
Author

Hi Jenny, sorry I didn't realise I could comment here until a couple of hours ago. Thank you for reviewing my wireframe and for the clear instructions as to what I had to amend to get the project right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants