-
-
Notifications
You must be signed in to change notification settings - Fork 266
London | May-2025 | Hendrine Zeraua| Wireframe #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@rarityXtreme - The information you provided on your webpage is great. Your page title, page description and footer are styled according to the wireframe. 👍 However, the main content of the page needs to be styled as close to the wireframe as possible. 👀 Notice how the main content has an article that takes up a large portion of the page (centered) and then the two other articles are centered underneath the first article? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking much closer to the wirefreame now. 👍
I think you can still get it closer to the exercise requirements.
- the width of the 2 bottom articles should span the same width as the top article. Currently, your bottom two articles are spanning wider than the top article.
- The short description underneath the page title is a bit too wide. Can you shorten your description a bit?
Hi Jenny, sorry I didn't realise I could comment here until a couple of hours ago. Thank you for reviewing my wireframe and for the clear instructions as to what I had to amend to get the project right. |
Self checklist
of this task
Changelist
semantic elements. It includes:
Questions
No questions at this time.
.