Skip to content

ZA | MAY-2025 | NOKWANDA PHEWA | WIREFRAME #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NokwandaPhewa
Copy link

@NokwandaPhewa NokwandaPhewa commented May 19, 2025

Complete the task list below this message.
If your PR is rejected, check the task list.

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
    Used git add . for related changes

  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
    CAPE TOWN | ITP-MAY-25 | NOKWANDA_PHEWA | WIREFRAME

  • I have tested my changes
    Tested on chrome lighthouse and firefox

  • My changes follow the [style guide](https://curriculum.codeyourfuture.io/guides/reviewing/style-guide/
    YES

  • My changes meet the requirements of this task
    YES

Changelist

-Implemented wireframe layout matching reference design
-added articles explaining - readme file,wireframes,git branches

  • footer

Copy link

netlify bot commented May 19, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit b9e550b
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/682ce2e8bee4ff00085c1e9e
😎 Deploy Preview https://deploy-preview-566--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 95 (🟢 up 9 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@NokwandaPhewa NokwandaPhewa added the Needs Review Participant to add when requesting review label May 20, 2025
@Waldo-Strydom Waldo-Strydom added 👀 Review Requirements Changes requested to meet requirements and removed Needs Review Participant to add when requesting review labels May 20, 2025
@Waldo-Strydom
Copy link

This does not follow the layout of the wireframe. Please fix it. Also please use the correct naming convention for your pr's

@NokwandaPhewa NokwandaPhewa changed the title CAPE TOWN | ITP-MAY-25 | NOKWANDA_PHEWA | WIREFRAME ZA | MAY-2025 | NOKWAZ PHEWA | WIREFRAME May 20, 2025
@NokwandaPhewa
Copy link
Author

"This does not follow the layout of the wireframe. Please fix it. Also please use the correct naming convention for your pr's"

I have corrected the layout ,could you kindly review @Waldo-Strydom

@NokwandaPhewa NokwandaPhewa changed the title ZA | MAY-2025 | NOKWAZ PHEWA | WIREFRAME ZA | MAY-2025 | NOKWANDA PHEWA | WIREFRAME May 20, 2025
@Waldo-Strydom
Copy link

Well done

@Waldo-Strydom Waldo-Strydom added Reviewed Volunteer to add when completing a review Complete Volunteer to add when work is complete and review comments have been addressed and removed 👀 Review Requirements Changes requested to meet requirements labels May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants