Northwest | May-2025 | Sofayas Solomon | Wireframe

[sofayas]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

• Built a web page following a wireframe structure.
• Used semantic HTML tags: <header>, <main>, <article>, and <footer>.
• Added three informational sections with placeholder images and links.
• Centered the title and short description in the header based on reviewer feedback.

Briefly explain your PR.

Centered the page title and description using CSS to align with the provided wireframe.

Replaced obsolete

tags with modern CSS practices.

Validated HTML code using W3C Markup Validation Service to ensure compliance.

Ask any questions you have for your reviewer.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	9d136c6
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/683ca3499867e9000858d427
😎 Deploy Preview	https://deploy-preview-576--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cjyuan]

Implementation looks good. Code is free of error and well indented.

Can you make these changes to further improve your implementation and PR?

1. When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you center the page title and the short description beneath the title?

2. To follow best practices, can you provide a brief description (under the "Changelist" section) summarizing the purpose of the PR and the changes you’ve made

[sofayas]

@cjyuan can you please review my work again so that i can complete my project on time. ps thank you for the comment

[cjyuan]

According W3C Markup Validation Service, there is an error in your code. Can you fix it? We may introduce new errors to our code whenever we make changes. So a good practice is to validate our code before submitting them for a review.

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

• Reply to their feedback. (Which you did. Great!)
  • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
  • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
• Replace the "Reviewed" label by a "Needs review" label

[sofayas]

@cjyuan Thanks for your feedback!
I’ve validated the updated HTML using the W3C validator and fixed the error.
I also reviewed my code formatting and double-checked for other issues. It should now be valid and ready for review again.

[cjyuan]

Well done!