Westmidland- May-2025- Ahmad Ehsas- Form control

[ahmadehsas]

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

• Add title for this From
• Add labels for Name and Email address
• Add labels for Choosing Colour
• Add labels for Choosing Size
• Add my name in the footer
• I have added a submit button to my form control
• I have added the pattern attribute to the input to ensure the user can't submit names with only spaces.

Questions

Kindly review my PRs.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	9e42d5d
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6838da388105610008775b57
😎 Deploy Preview	https://deploy-preview-588--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[ahmadehsas]

Kindly review my PRs

[cjyuan]

Code is free of errors and well-indented. Good job!

1. There isn't seem to be a way for the user to submit the form.

2. Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?

3. In the PR description, one of the "Self checklist" items was missing and the boxes were not checked. Can you restore the "Self checklist" items and check all the boxes (to indicate that you have followed all the guidelines to prepare this PR as best you can)?

[ahmadehsas]

Is it necessary to add the label " needs review" again?

[cjyuan]

If your PR is ready to be reviewed again, yes. :)

[ahmadehsas]

My PR is ready to be reviewed. kindly review my PR.
Thank you.

[ahmadehsas]

I removed the " Reviewed" lebel and added " Needs review", is it OK ?

[cjyuan]

1. The changes made in your HTML code looks good. Well done!

2. The Self-checklist boxes in your PR description are not yet checked. If you have performed what the the Self-checklist items describe (as best you can can), you should check the boxes.

Note:
In CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

• Reply to their feedback.
  • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
  • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
• Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)

[ahmadehsas]

Thanks for the reminder! I've now checked all the boxes in the self-checklist, as I followed all the required steps. Let me know if there's anything else to update.

[cjyuan]

Changes look good.

[ahmadehsas]

Thank you for taking the time to review my work. I appreciate your guidance and support.