west midlands | May-2025| Jabir Adam | Wireframe #597
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jenny-alexander
added
Review in progress
There was a problem hiding this comment.
Your wireframe page is looking pretty good. There are some fundamental exercise requirements missing though. I left comments in your code to help you fix them.
- Another suggestion is to use images that represent the article instead of the placeholder image (i.e. if the article is about a readme file, maybe you can show an image that depicts a readme file?)
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <h2> What is the purpose of a README file?</h2> | ||
| <p> |
There was a problem hiding this comment.
If you review the exercise requirements, you'll see that the wireframe has the title description centered on the page. As much as possible, try to always create your webpage so it is similar to the wireframe!
| </p> | ||
| </header> | ||
| <main> | ||
|
|
||
|
|
||
| <article> | ||
| <img src="placeholder.svg" alt="" /> |
There was a problem hiding this comment.
Can you review the required attributes of the <img> element? You're missing an important one.
| A README file serves as an introductory document for a software project or dataset, providing users with essential information about what the project does, how to use it, and how to get started. It's a crucial piece of documentation that helps users understand the project's purpose, | ||
| requirements, and installation/usage instructions | ||
|
|
||
|
|
||
| </p> | ||
| <a href="">Read more</a> |
There was a problem hiding this comment.
The 'Read More' button should bring to the user to a web page that gives more information about the article.
|
|
||
|
|
||
| </p> | ||
| <a href="">Read more</a> |
There was a problem hiding this comment.
The 'Read More' button should bring to the user to a web page that gives more information about the article.
| A branch in Git is simply a lightweight movable pointer to one of these commits. The default branch name in Git is master . As you start making commits, you're given a master branch that points to the last commit you made. Every time you commit, | ||
| the master branch pointer moves forward automatically | ||
| </p> | ||
| <a href="">Read more</a> |
There was a problem hiding this comment.
The 'Read More' button should bring to the user to a web page that gives more information about the article.
|
|
||
|
|
||
| <article> | ||
| <img src="placeholder.svg" alt="" /> |
There was a problem hiding this comment.
Can you review the <img> element and the alt attribute?
|
|
||
|
|
||
| <article> | ||
| <img src="placeholder.svg" alt="" /> |
There was a problem hiding this comment.
Can you review the <img> element and the alt attribute?
| </main> | ||
|
|
||
|
|
||
| <footer > |
There was a problem hiding this comment.
Your footer shows valuable information (i.e. your name), however the requirement for the footer is:
The page footer is fixed to the bottom of the viewport.
Can you fix this? If you're not sure what 'fixed to the bottom of the viewport mean', try searching it via web search or asking chatGPT.
jenny-alexander
added
Reviewed
Self checklist
Changelist
I had change the web Wireframe and did every thing as readme asked me to do
Ask any questions you have for your reviewer.