Sheffield | May2025 | Waleed Salih Taha| wireframe #617
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2. and published a brunch 3. commited the brunch 4. added CSS styling to the code
There was a problem hiding this comment.
-
According to the W3C Markup Validation Service, there is a syntax error in your HTML code. Can you fix it?
-
When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you center the page title, the short description beneath the title, and the text in the footer?
Wireframe/index.html
Outdated
| A Git branch represents an independent line of development from the main codebase. | ||
| By default, Git projects start with a main branch called "master". | ||
| When you create a new branch, you're making a parallel version that you can | ||
| work on without impacting that main code. | ||
| It's like having alternate realities! The master branch represents the production version | ||
| that your users see. And feature branches represent experimental states that aren't ready to go live. |
There was a problem hiding this comment.
This text is not properly indented.
You can use VSCode's "Format Document" feature to format your code for better readability and consistency.
To use the feature, right-click inside the code editor and select the option.
Please note that if there are syntax errors in the code, the "Prettier" extension may not format HTML code properly.
cjyuan
added
Reviewed
|
You changed the label but I don't see any new commits being pushed to Github. Did you forget to push you changes to Github? The preview page https://deploy-preview-617--cyf-onboarding-module.netlify.app/wireframe/ remains unchanged. |
|
I still don't see any new changes committed to this branch. Did you push your changes made on your computer to Github? The most recent commit on this branch was made on 29 May. |
2. Uses shadows, spacing, and padding for a clean UI. 3. Stack layout on small screens with readable fonts. 4. Ensures placeholder images don't stretch. 5. Adds interactivity and polish without overcomplicating. 6. Responsive structure hooks (classes + semantics). 7.Improved accessibility (alt text, external link behavior). 8. Semantic improvements (removed unnecessary <header> inside <article>).
|
Page nicely styled.
|
Learners, PR Template
Self checklist
Changelist
implementation of the wireframe exercise
Questions
Ask any questions you have for your reviewer.