Skip to content

NW7 | Sue Mohamadi | Module-Structuring-and-Testing-Data | module 2/ week 3 (Sprint-3 exercises) #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

NW7 | Sue Mohamadi | Module-Structuring-and-Testing-Data | module 2/ week 3 (Sprint-3 exercises) #114

wants to merge 42 commits into from

Conversation

SueMsOl
Copy link

@SueMsOl SueMsOl commented Nov 10, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

SueMsOl and others added 30 commits October 23, 2024 01:20
@SueMsOl
a new dir called prep for ITP3
9e19f9c
@SueMsOl
identified and resolved the bugs inside files located in errors direc…
f99f9ca 
…tory.
@SueMsOl
interpreted syntax / operators / functions inside interpret directory…
554cc2a 
… files in Sprint 1 directory.
@SueMsOl
looked up for unfamiliar syntax in exercises dir inside sprint 1 dire…
0ef45a8 
…ctory
@SueMsOl
Merge pull request #1 from SueMsOl/MSATD-sprint1
7a52923 
Msatd sprint1
@SueMsOl
finished tasks in interpret dir and explore dir in sprint 1 directory
99071e5
@SueMsOl
Merge pull request #2 from SueMsOl:MSATD-sprint2
8453583 
MSATD-sprint2
@SueMsOl
fixed 0.js error in errors dir
17c0a54
@SueMsOl
fixed error in 1.js file in errors dir
7a5a029
@SueMsOl
fixed error in 2.js file in errors dir
0110569
@SueMsOl
fixed code in 0.js file in debug dir
f56ab0a
@SueMsOl
debugged 1.js file in debug dir
bd89557
@SueMsOl
debugged 2.js file on debug dir
4ddc809
@SueMsOl
debugged format-time.js file on extend dir
7937b18
@SueMsOl
created a function for bmi.js in implement dir
415d9bd
@SueMsOl
finished bmi function
576cf92
@SueMsOl
finished cases function in cases.js
f3e6bd0
@SueMsOl
finished toPounds function in pounds.js
9e91758
@SueMsOl
made to-Pounds function code DRYER
45405ca
@SueMsOl
finished writing function in vat.js
78d023c
@SueMsOl
finished time-formats.js exercise
33f05f9
@SueMsOl
fixed toPounds function bug in pounds.js
b55b233
@SueMsOl
fixed bug in pounds.js
5092bca
@SueMsOl
fixed all bugs on pounds.js
87cdd24
@SueMsOl
made cases.js code dryer
b7695a7
@SueMsOl
updated toPounds3 function in pounds.js
3ce6b53
@SueMsOl
I have installed jest framework, and ran example.test.js to see if it…
df206b2 
… is working
@SueMsOl
wrote function in get-angle-type file and tested it using JIST framework
56f1cf1
@SueMsOl
wrote function in get-card-value file and tested it using JIST framework
2ac16f3
@SueMsOl
wrote function in is-proper-fraction file and tested it using JIST fr…
fef5b77 
…amework
SueMsOl and others added 11 commits November 7, 2024 23:15
@SueMsOl
wrote function in is-valid-triangle file and tested it using JIST fra…
0e7e294 
…mework
@SueMsOl
wrote function in rotate.char.js file and tested it using JIST framework
a063e7d
@SueMsOl
installed JIST framework in implement directory inside revise directory
fca2b8d
@SueMsOl
wrote 6 different functions in password-validator.test.js for each co…
518b44d 
…ndition (for practice)
@SueMsOl
an unresolved bug in passValidChecker function in password-validator.…
7876ea0 
…test.js
@SueMsOl
wrote functions required in 3 files inside revise/implement directory
0dbd853
@SueMsOl
wrote functions required in repeat.test.js file inside revise/impleme…
f2d4b55 
…nt directory
@SueMsOl
wrote functions required in is-prime.test.js file inside revise/imple…
b78e1aa 
…ment directory
@SueMsOl
wrote functions required in password-validator.test.js file inside re…
7324324 
…vise/implement directory
@SueMsOl
wrote functions required in password-validator.test.js file inside re…
557660c 
…vise/implement directory
@SueMsOl
Merge pull request #3 from SueMsOl/MSATD-sprint2
f20d6a1 
sprint 3 exercises
@SueMsOl SueMsOl added the Needs Review Participant to add when requesting review label Nov 10, 2024
SallyMcGrath
SallyMcGrath suggested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SueMsOl it looks like you've committed ALL your changes into one giant PR. Lots of people get mixed up with this at first, so come to class and get help sorting out your PR.

You can look here https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/pull/114/files

to see what I mean. We only want the changes for week 3 in this PR, not all changes

@SallyMcGrath SallyMcGrath added 👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SallyMcGrath SallyMcGrath SallyMcGrath requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SueMsOl @SallyMcGrath