Sprint 2 #146

Della-Bella · 2024-11-15T09:05:22Z

LONDON | GISLAINE_DELLA_BELLA | MODULE-STRUCTURING-AND-TESTING-DATA | SPRINT-2

Self checklist

[X ] I have committed my files one by one, on purpose, and for a reason
[X ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[X ] I have tested my changes
[X ] My changes follow the style guide
[X ] My changes meet the requirements of this task

Questions

Hello Volunteer, good morning
Here are my exercises for review.
Thank you for taking the time to review them. I appreciate it,
Gislaine

…e num

…ect the function

SallyMcGrath

Hi there @Della-Bella

Oh, I think we already hit this problem on another PR. This is still quite mixed up, so please ask to pair with someone to go through opening a PR, branching, and checking what it is actually in your commit before you push it. You'll get it, don't worry!

SallyMcGrath

Thanks for your hard work here, @Della-Bella .

I think it would be a good idea to spend a bit more time on this. There are some foundational concepts that you need to work on here. Book some time in with me or with another volunteer in the pair programming channel and we can walk through this coursework step by step.

You can do this. You will get there.

SallyMcGrath · 2024-12-06T14:33:22Z

Sprint-2/debug/0.js

+
+DEBUG*/
+
+//The result of multiplying 10 and 32 is 320


Did this prediction bear out, or did it print undefined? Why did it do this?

The function wasn't called initially, so it didn't display the result. However, it has now been called and is returning the result.

SallyMcGrath · 2024-12-06T14:33:54Z

Sprint-2/debug/1.js

+//FIX://
+
+function sum(a, b) {
+  return; a + b;


When you executed this function, did this fix work? 🤔

This fix didn't work because the sum of "a" and "b" wasn't included. Now I have fixed the code, and it is returning the result.

SallyMcGrath · 2024-12-06T14:34:43Z

Sprint-2/debug/2.js

-// This program should tell the user the last digit of each number.
-// Explain why getLastDigit is not working properly - correct the problem
+/* This program should tell the user the last digit of each number.
+ the function doesn’t have a parameter to receive the num variable it’s trying to process. 


This is true, but not complete. It doesn't have a parameter, so why is it returning 3? Where does the 3 come from?

The function was using the same variable every time. Adding a parameter to the function fixed it.T

SallyMcGrath · 2024-12-06T14:36:04Z

Sprint-2/errors/1.js

@@ -3,11 +3,14 @@
 // Why will an error occur when this program runs?
 // Try playing computer with the example to work out what is going on


What do you think? Why is this happening? What is the fix?

Remove the duplicated declaration. With this commit

SallyMcGrath · 2024-12-06T14:36:28Z

Sprint-2/errors/2.js



+/* this function should square any number but instead we're going to get an error
+ Fix 3 is not valid parameter name. should change function name to square(num)


What is the error, specifically?

The error was with parameter 3, which always gave me the same result. By changing it to "num," the function now works with any number. Also 3 is used as the parameter name for the function, which is not valid in JavaScript.

SallyMcGrath · 2024-12-06T14:37:21Z

Sprint-2/implement/bmi.js

@@ -13,3 +13,24 @@
 // Given someone's weight in kg and height in metres
 // Then when we call this function with the weight and height
 // It should return their Body Mass Index to 1 decimal place
+
+
+function ibmCalculator() {


What would happen if you had a different height or weight?

I understand now why it was giving the same results. I removed the constant from inside the function and fixed the height units.

Fix the units/ removed the constant values

SallyMcGrath · 2024-12-06T14:38:15Z

Sprint-2/myexc2.js

+  `current output: ${currentOutput}, target output: ${targetOutput}`
+);*/
+
+function formatAs12HourClock(time) {


What would happen if the time was in the afternoon?

It wouldn't work. Fix the function to the 12 hours format.

Della-Bella added 22 commits November 11, 2024 18:46

Debug exercise 0.js undefined function values

c36d5b3

Debug error line "return"

fe4ebe8

Debug 2.js.The function don't have a parameter to receive the variabl…

03b3c5e

…e num

my practice exercise/ explain assert

6dc1cb6

SyntaxError: Identifier 'str' has already been declared/ defined corr…

5e34bb5

…ect the function

Fixed error function name/ 3 is not a valid name

856a3f5

Fixed Function name error/ 3 is not a valid name

3cbc91a

Format Time console.assert practice

f2a9162

Practice Function UpperCase

a271680

Practicing Function toUpperCase

b069435

Applying Function toUpperCase

1de6b0f

Code function to add % on a value number

2d6c264

Function Vat add % to a number

5930178

Add Comments to a line in java Script //

bfdb3fb

Creating Function BMI

4116ead

creating Function bmi

11078e5

code revision

e8723c0

Function Time Formatting explained

3e7b813

Interpreting Time Formatting Function

1b49ee2

Interpreting Function Time formatting

32dfaaa

Function to.pound reusable block

2bbcf99

Revising function % vat

7ce5b80

Della-Bella added the Needs Review Participant to add when requesting review label Nov 15, 2024

SallyMcGrath suggested changes Nov 18, 2024

View reviewed changes

SallyMcGrath added 👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Nov 18, 2024

SallyMcGrath reviewed Dec 6, 2024

View reviewed changes

Della-Bella added 2 commits December 21, 2024 11:54

Debugging the error

6f78ed9

Fixing function returning the Sum

661fd6d

Della-Bella added 8 commits December 21, 2024 12:42

Fix it

17f8b03

Declared the function

9b2ceee

Removed the duplicated declaration

17d1618

Fixing changing the name of the function.

f519e88

Fix the units/ removed the constant values

8631aae

Fix the function convert numbers to 12 hours format

d4486d6

shor wat to implemeting ++1 = count++;

616ef23

Fix the count++;

a8316b9

Della-Bella added the Complete Volunteer to add when work is complete and review comments have been addressed label Jan 15, 2025

		@@ -3,11 +3,14 @@
		// Why will an error occur when this program runs?
		// Try playing computer with the example to work out what is going on



		/* this function should square any number but instead we're going to get an error
		Fix 3 is not valid parameter name. should change function name to square(num)

Uh oh!

Sprint 2 #146

Are you sure you want to change the base?

Sprint 2 #146

Uh oh!

Conversation

Della-Bella commented Nov 15, 2024

Questions

Uh oh!

SallyMcGrath left a comment

Choose a reason for hiding this comment

Uh oh!

SallyMcGrath left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!