Skip to content

West Midlands | Gabriel Deng | Module-Structuring-and-Testing-Data | Sprint-2 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

West Midlands | Gabriel Deng | Module-Structuring-and-Testing-Data | Sprint-2 #153

wants to merge 13 commits into from

Conversation

gai93003
Copy link

@gai93003 gai93003 commented Nov 16, 2024 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

gai93003 added 13 commits October 28, 2024 18:44
@gai93003
The error was a hosting error which i have corrected.
bb0d4e9
@gai93003
Line 3 is about an assignment operator.
e328f4f
@gai93003
The code is correct.
8db87e9
@gai93003
Variable names can't start with numbers or contain reserved names.
4897e39
@gai93003
I have created the three variables, wholeNumberPart, decimalPart and …
058e792 
…roundedNum
@gai93003
I accessed the first character by indexing. The first initials are th…
ada4d4d 
…en put together by using addition operator
@gai93003
I used the slice to find the dir from the first character to the the …
83891e4 
…lastSlashIndex
@gai93003
I used slice method to find the occurance of '.' and then add 1 to fi…
4a3908b 
…nd the next value to it.
@gai93003
I used toString method on the cardNumber to turn it into strings and …
992c112 
…then used slice to retrieve the last 4 digits
@gai93003
The variable names were not descriptive enough.
ca90c22
@gai93003
I created a new variable to store the strings created from the cardNu…
a16785e 
…mber
@gai93003
I corrected a bug inorder to get the last character in a variable of …
00e0ba9 
…numbers converted to strings
@gai93003
I attempted the exercises in sprint 2
56bbf58
@gai93003 gai93003 added the Needs Review Participant to add when requesting review label Nov 16, 2024
SallyMcGrath
SallyMcGrath suggested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @gai93003

It looks like you have opened your sprint 2 branch from your sprint 1 branch, instead of main. Take a look https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/pull/153/files

You have loads more files than you should. Lots of people have trouble with this, so look in the questions channel on Slack to get help with fixing this. Good luck!

@SallyMcGrath SallyMcGrath added 👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Nov 18, 2024
@gai93003
Copy link
Author

Thanks for the pointing that out Sally, I will work on that next time.

@gai93003 gai93003 added the Complete Volunteer to add when work is complete and review comments have been addressed label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SallyMcGrath SallyMcGrath SallyMcGrath requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed 👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gai93003 @SallyMcGrath