Skip to content

ITP | SAMI SARDARZAI | Module-Structuring-and-Testing-Data | WEEK 2 #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

samisardarzai
Copy link

@samisardarzai samisardarzai commented Nov 27, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@samisardarzai samisardarzai added the Needs Review Participant to add when requesting review label Nov 27, 2024
@samisardarzai samisardarzai requested review from sjdonado and illicitonion and removed request for sjdonado November 27, 2024 14:38
Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He @samisardarzai

You have added all your files from last sprint into this one, so it's a huge mess.

When you open a branch, you must open it from MAIN. If you open a branch from sprint 1, everything you did in sprint 1 will be included.

Bring your work to class to learn how to fix this. It's really important that you get your mental model of git working properly, or you won't be able to collaborate with other people on projects. Good luck!

@SallyMcGrath SallyMcGrath added 👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants