London- ITP January | Shohreh Bayat | Structuring and testing data | Week 1 #268
Conversation
Shohreh-bayat
changed the title
|
I forgot to commit one by one, and when I entered all my answers, I remembered that I had to commit one by one. So sorry about that. |
halilibrahimcelik
added
Review in progress
|
I realized you did not finish 1-key-exercises, I encourage you to also finish that part as well. |
It is essential to divide and commit your changes separately, this would be both helpful for reviewers as well as for you to inspect your changes. |
| const cityOfBirth = "Bolton"; | ||
| console.log(`I was born in ${cityOfBirth}`); | ||
|
|
There was a problem hiding this comment.
what was the error can you also explain it please ?
| const last4Digits = cardNumber.slice(-4); | ||
| const last4Digits = cardNumber.toString().slice(-4); | ||
| console.log (last4Digits) | ||
|
|
||
|
|
||
| // The last4Digits variable should store the last 4 digits of cardNumber | ||
| // However, the code isn't working | ||
| // Before running the code, make and explain a prediction about why the code won't work | ||
| // Then run the code and see what error it gives. | ||
| // Consider: Why does it give this error? Is this what I predicted? If not, what's different? |
There was a problem hiding this comment.
It is important to understand why we got an error in the first place, can you explain what causes the error
| // b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem? | ||
| //SyntaxError: missing ) after argument list. priceAfterOneYear = Number(priceAfterOneYear.replaceAll("," "")); | ||
|
|
There was a problem hiding this comment.
are you sure "missing )" is the reason behind syntax error ?
halilibrahimcelik
added
👀 Review Git
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.