Skip to content

ITP_JAN | KATARZYNA_KAZIMIERCZUK | STRUCTURING_AND_TESTING_DATA | SPRINT_3 #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

katarzynakaz
Copy link

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Completed Sprint 3 exercises.

Questions

No questions. A note on the username - cyf laptop hence the username comes up as cyf.

@shieldo
Copy link

shieldo commented Mar 13, 2025

Hey @katarzynakaz ! You should be able to set git up on your machine to use an email address associated with your GitHub (there's even an option to use an internal GitHub email address so your address isn't made public) - try the how-to here: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#setting-your-commit-email-address-on-github

Copy link

@shieldo shieldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good stuff! There's a minor error in one of the tests, but aside from that, you seem to have a good understanding of this.

@shieldo shieldo added the Reviewed Volunteer to add when completing a review label Mar 13, 2025
@katarzynakaz
Copy link
Author

Hey @katarzynakaz ! You should be able to set git up on your machine to use an email address associated with your GitHub (there's even an option to use an internal GitHub email address so your address isn't made public) - try the how-to here: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#setting-your-commit-email-address-on-github

Thank you, I have done it after I did the PR. According to the documentation my address for previous commits won't be updated. "Any commits you made prior to changing your commit email address are still associated with your previous email address."

@shieldo
Copy link

shieldo commented Mar 15, 2025 via email

@shieldo
Copy link

shieldo commented Mar 19, 2025

@katarzynakaz Thanks for this extra improvement to the PR!

@katarzynakaz katarzynakaz added the Complete Participant to add when work is complete and review comments have been addressed label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants