-
-
Notifications
You must be signed in to change notification settings - Fork 116
ITP_JAN | KATARZYNA_KAZIMIERCZUK | STRUCTURING_AND_TESTING_DATA | SPRINT_3 #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hey @katarzynakaz ! You should be able to set git up on your machine to use an email address associated with your GitHub (there's even an option to use an internal GitHub email address so your address isn't made public) - try the how-to here: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#setting-your-commit-email-address-on-github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good stuff! There's a minor error in one of the tests, but aside from that, you seem to have a good understanding of this.
Thank you, I have done it after I did the PR. According to the documentation my address for previous commits won't be updated. "Any commits you made prior to changing your commit email address are still associated with your previous email address." |
That's fine :) just making sure that you are set up now!
…On Sat, 15 Mar 2025, 10:54 katarzynakaz, ***@***.***> wrote:
Hey @katarzynakaz <https://github.com/katarzynakaz> ! You should be able
to set git up on your machine to use an email address associated with your
GitHub (there's even an option to use an internal GitHub email address so
your address isn't made public) - try the how-to here:
https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#setting-your-commit-email-address-on-github
Thank you, I have done it after I did the PR. According to the
documentation my address for previous commits won't be updated. "Any
commits you made prior to changing your commit email address are still
associated with your previous email address."
—
Reply to this email directly, view it on GitHub
<#353 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXYAEY5WB7WUSHW6LDLT32UQBGLAVCNFSM6AAAAABYR4T3HWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRWGQZTSMJSGE>
.
You are receiving this because you commented.Message ID:
<CodeYourFuture/Module-Structuring-and-Testing-Data/pull/353/c2726439121@
github.com>
[image: katarzynakaz]*katarzynakaz* left a comment
(CodeYourFuture/Module-Structuring-and-Testing-Data#353)
<#353 (comment)>
Hey @katarzynakaz <https://github.com/katarzynakaz> ! You should be able
to set git up on your machine to use an email address associated with your
GitHub (there's even an option to use an internal GitHub email address so
your address isn't made public) - try the how-to here:
https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#setting-your-commit-email-address-on-github
Thank you, I have done it after I did the PR. According to the
documentation my address for previous commits won't be updated. "Any
commits you made prior to changing your commit email address are still
associated with your previous email address."
—
Reply to this email directly, view it on GitHub
<#353 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXYAEY5WB7WUSHW6LDLT32UQBGLAVCNFSM6AAAAABYR4T3HWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRWGQZTSMJSGE>
.
You are receiving this because you commented.Message ID:
<CodeYourFuture/Module-Structuring-and-Testing-Data/pull/353/c2726439121@
github.com>
|
@katarzynakaz Thanks for this extra improvement to the PR! |
Self checklist
Changelist
Completed Sprint 3 exercises.
Questions
No questions. A note on the username - cyf laptop hence the username comes up as cyf.