ITP-JAN 2025 | London | ELVIRA MLADENOVA | MODULE-STRUCTURING AND TESTING DATA | Week 4 | Sprint1 #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halilibrahimcelik
added
Review in progress
halilibrahimcelik
approved these changes
Mar 16, 2025
| @@ -2,3 +2,7 @@ | |||
|
|
|||
| const age = 33; | |||
| age = age + 1; | |||
|
|
|||
There was a problem hiding this comment.
Please remove duplicate code above which causes an error
| //corrected: | ||
| const hourClockTime24 = "20:53"; | ||
| const hourClockTime12 = "08:53"; |
There was a problem hiding this comment.
You fixed all errors in the files but you forgot to comment out initial lines that caused error in the first place
halilibrahimcelik
added
Reviewed
|
thank you Halil for your review. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.