ITP JAN | ELVIRA MLADENOVA | MODULE-STRUCTURING AND TESTING DATA | COURSEWORK SPRINT 3 | WEEK 6 #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@halilibrahimcelik |
halilibrahimcelik
requested changes
Mar 16, 2025
| const str = "hello"; | ||
| const count = -1; | ||
| expect(() => repeat(str, count)).toThrow("Count must be a non-negative integer"); | ||
| }); |
There was a problem hiding this comment.
Please check your repeat.js logic, when I run all tests, repeat.test failed. Please make sure you meet test expectations
There was a problem hiding this comment.
I corrected the mistake and committed the changes. Thank you.
There was a problem hiding this comment.
looking good, you can close this pr.
halilibrahimcelik
added
Review in progress
emladeno
added
the
Complete
halilibrahimcelik
added
Reviewed
halilibrahimcelik
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.