ITP JAN25 | KATARZYNA_KAZIMIERCZUK | STRUCTURING_AND_TESTING_DATA | SPRINT2 #434

katarzynakaz · 2025-03-29T07:52:30Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

cjyuan

I have left you some feedback for your work in Sprint-2.

This branch should not contain modified files in Sprint-1 and Sprint-3 folders.

Since this PR has not yet been reviewed, I will removed the "Complete" label for now. You can add them after you have made the necessary changes.

cjyuan · 2025-04-20T23:20:48Z

Sprint-2/3-mandatory-implement/1-bmi.js

+    let heightCM = heightM/100
+    return parseFloat((weight / (heightCM*heightCM))).toFixed(1); 
+}


What type of value do you think the function should return? A number or a string?
Does your function return the type of value you think it should return?

it was incorrect, it is now fixed

Sprint-2/3-mandatory-implement/2-cases.js

cjyuan · 2025-04-20T23:37:19Z

Sprint-2/4-mandatory-interpret/time-format.js

+//3
 // Call formatTimeDisplay with an input of 61, now answer the following:

 // b) What is the value assigned to num when pad is called for the first time?
 // =============> write your answer here
+// 61

 // c) What is the return value of pad is called for the first time?
 // =============> write your answer here
+// num 0

 // d) What is the value assigned to num when pad is called for the last time in this program?  Explain your answer
 // =============> write your answer here
+// TypeError: num.toString(...).padStart is not a function an error shows
+

 // e) What is the return value assigned to num when pad is called for the last time in this program?  Explain your answer
 // =============> write your answer here
+// TypeError: num.toString(...).padStart is not a function an error shows


"Python Tutor: Visualize Code" does not support newer version of JS, and that's why you get the error " TypeError: num.toString(...).padStart is not a function".

The answers to (b) is not quite correct.
Question (b) basically asks, among the function calls, pad(totalHours), pad(remainingMinutes), and pad(remainingSeconds) at line 11, which function gets called first? If you can figure out which function gets called first, then what is the parameter of that function call?

Forget about the Code Visualizer. What is your expected answers for (d) and (e).
You can ask ChatGPT for second opinion or you can execute the code in browser's JS console.

fixed in the other PR

katarzynakaz · 2025-04-21T21:45:00Z

I have left you some feedback for your work in Sprint-2.

This branch should not contain modified files in Sprint-1 and Sprint-3 folders.

Since this PR has not yet been reviewed, I will removed the "Complete" label for now. You can add them after you have made the necessary changes.

Apologies, I now added a replacement PR not including sprint 1 and 2 coursework
#448

cjyuan · 2025-04-22T01:54:56Z

You don't have to create a new branch. One way to fix the branch is replace the "modified files" in Sprint-1 and Sprint-3 folders by the same files from your main branch in the following way:

Download a your main branch as a ZIP file from https://github.com/katarzynakaz/fModule-Structuring-and-Testing-Data/tree/main
In your local repo (the folder where you keep the clone of your repo), switch to branch sprint2
Copy the subfolders, "Sprint-1" and "Sprint-3", from the ZIP file to your local repo (which will replace the modified files in those sub-folders in branch sprint2)
Commit the change
Push the change to Github

cjyuan · 2025-04-22T01:55:56Z

If you insist of using the new branch, then you will have to close this PR, and then respond to the feedback I left here in your new branch.

katarzynakaz · 2025-04-22T14:58:08Z

You don't have to create a new branch. One way to fix the branch is replace the "modified files" in Sprint-1 and Sprint-3 folders by the same files from your main branch in the following way:

Download a your main branch as a ZIP file from https://github.com/katarzynakaz/fModule-Structuring-and-Testing-Data/tree/main

In your local repo (the folder where you keep the clone of your repo), switch to branch sprint2

Copy the subfolders, "Sprint-1" and "Sprint-3", from the ZIP file to your local repo (which will replace the modified files in those sub-folders in branch sprint2)

Commit the change

Push the change to Github

thank you! everything is fixed on this PR

cjyuan

Still have room to improve.

cjyuan · 2025-04-22T15:25:54Z

Sprint-2/4-mandatory-interpret/time-format.js

@@ -23,17 +23,16 @@ function formatTimeDisplay(seconds) {

 // b) What is the value assigned to num when pad is called for the first time?
 // =============> write your answer here
-// 61
+// 60


The answer is not 60. Please retry.

cjyuan · 2025-04-22T15:28:56Z

Sprint-2/4-mandatory-interpret/time-format.js


 // c) What is the return value of pad is called for the first time?
 // =============> write your answer here
-// num 0
+// 00


If the type of the value is a string, we can denote it as "00" to make it clearer its type and value.

cjyuan · 2025-04-22T15:32:25Z

Sprint-2/3-mandatory-implement/2-cases.js

@@ -15,7 +15,7 @@
 // Use the MDN string documentation to help you find a solution
 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase

-const convertToUpper = (word) => word.toUpperCase()
+const convertToUpper = (word) =>
+  input.replace(/ /g, "_").console.log(convertToUpper("kaska"));


Does this statement (at line 19) work?

cjyuan · 2025-04-22T15:33:58Z

Sprint-2/3-mandatory-implement/1-bmi.js

+  let heightCM = heightM / 100;
+  return parseFloat(weight / (heightCM * heightCM)).toFixed(1);


What type of value do you think the function should return? A number or a string?
Does your function return the type of value you think it should return?

cyf and others added 7 commits March 7, 2025 13:03

key-implement done

9da601e

rewrte-done

1318915

sprint 3 finito

c6a0ae7

issues fixed

4583404

sprint1

4ad6694

sprint2

4e17876

fixes after review

4c137b3

katarzynakaz added Needs Review Participant to add when requesting review Complete Participant to add when work is complete and review comments have been addressed labels Apr 19, 2025

cjyuan reviewed Apr 20, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review Complete Participant to add when work is complete and review comments have been addressed labels Apr 20, 2025

katarzynakaz added 2 commits April 22, 2025 15:50

sprint 1 and 3 files replaced with main branch

64169aa

sprint 2 issues addressed

58e1e16

cjyuan reviewed Apr 22, 2025

View reviewed changes

cjyuan mentioned this pull request Apr 22, 2025

ITP JAN 25 | Katarzyna Kazimierczuk | Structuring And Testing Data | Sprint 2 (recreated) #448

Closed

5 tasks

sprint 2 typos fixed

983e0b3

katarzynakaz added the Complete Participant to add when work is complete and review comments have been addressed label Apr 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ITP JAN25 | KATARZYNA_KAZIMIERCZUK | STRUCTURING_AND_TESTING_DATA | SPRINT2 #434

ITP JAN25 | KATARZYNA_KAZIMIERCZUK | STRUCTURING_AND_TESTING_DATA | SPRINT2 #434

katarzynakaz commented Mar 29, 2025 •

edited

Loading

cjyuan left a comment

cjyuan Apr 20, 2025

katarzynakaz Apr 22, 2025

cjyuan Apr 20, 2025

katarzynakaz Apr 21, 2025

katarzynakaz commented Apr 21, 2025

cjyuan commented Apr 22, 2025

cjyuan commented Apr 22, 2025

katarzynakaz commented Apr 22, 2025

cjyuan left a comment

cjyuan Apr 22, 2025

cjyuan Apr 22, 2025

cjyuan Apr 22, 2025

cjyuan Apr 22, 2025

		let heightCM = heightM / 100;
		return parseFloat(weight / (heightCM * heightCM)).toFixed(1);

ITP JAN25 | KATARZYNA_KAZIMIERCZUK | STRUCTURING_AND_TESTING_DATA | SPRINT2 #434

Are you sure you want to change the base?

ITP JAN25 | KATARZYNA_KAZIMIERCZUK | STRUCTURING_AND_TESTING_DATA | SPRINT2 #434

Conversation

katarzynakaz commented Mar 29, 2025 • edited Loading

Learners, PR Template

Changelist

Questions

cjyuan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katarzynakaz commented Apr 21, 2025

cjyuan commented Apr 22, 2025

cjyuan commented Apr 22, 2025

katarzynakaz commented Apr 22, 2025

cjyuan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katarzynakaz commented Mar 29, 2025 •

edited

Loading