Skip to content

ITP JAN 2025 LONDON| ELFREDAH KEVIN-ALERECHI |Structuring-and-Testing-Data| SPRINT 1 #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Elfredah
Copy link

@Elfredah Elfredah commented Apr 1, 2025

Self checklist

  • [ X] I have committed my files one by one, on purpose, and for a reason
  • [ X] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • [ X] I have tested my changes
  • [ X] My changes follow the style guide
  • [ X] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

const percentageChange = (priceDifference / carPrice) * 100;

console.log(`The percentage change is ${percentageChange}`);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% could be added here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. % has been added to console.log(The percentage change is ${percentageChange}%)

@fearcyf fearcyf added the Reviewed Volunteer to add when completing a review label Apr 14, 2025
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added few comments.


// Declare a variable called initials that stores the first character of each string.
// This should produce the string "CKJ", but you must not write the characters C, K, or J in the code of your solution.

let initials = ``;
let initials = "firstName[0] + middleName[0] + lastName[0]";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this statement, the value assigned to initials is not "EKA" (the first character of each string).

const ext = ;
//SOLUTIONS BELOW

const dir ="filePath.slice(0, lastSlashIndex)";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This statement does not assign the dir part to dir.

Comment on lines 21 to +22
What is the return value of `prompt`?
It says undefined
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prompt() should not have returned undefined. You can look up the function at MDN to find out what its return value is.

Comment on lines 13 to +15
What effect does calling the `alert` function have?
//RESPONSE
It says undefined
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't you see anything happened in the browser when your call alert("Hello world!") in the browser JS console?

@Elfredah Elfredah added the 👀 Review Testing Changes requested to do with testing label Apr 15, 2025
@cjyuan
Copy link

cjyuan commented Apr 15, 2025

You should respond to all comments given by the reviewers, update your code accordingly, and then push the files you changed on your computer to Github. If you don't push the files to Github, reviewer won't be able to see the changes you made.

And after you have made the necessary changes and push your changes to Github, you should add "Needs review" label (if you want the reviewer to review the changes you made).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Review Testing Changes requested to do with testing Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants