-
-
Notifications
You must be signed in to change notification settings - Fork 117
ITP JAN 2025 LONDON| ELFREDAH KEVIN-ALERECHI |Structuring-and-Testing-Data| SPRINT 1 #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
const percentageChange = (priceDifference / carPrice) * 100; | ||
|
||
console.log(`The percentage change is ${percentageChange}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
% could be added here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. % has been added to console.log(The percentage change is ${percentageChange}%
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added few comments.
|
||
// Declare a variable called initials that stores the first character of each string. | ||
// This should produce the string "CKJ", but you must not write the characters C, K, or J in the code of your solution. | ||
|
||
let initials = ``; | ||
let initials = "firstName[0] + middleName[0] + lastName[0]"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this statement, the value assigned to initials
is not "EKA" (the first character of each string).
const ext = ; | ||
//SOLUTIONS BELOW | ||
|
||
const dir ="filePath.slice(0, lastSlashIndex)"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This statement does not assign the dir part to dir
.
What is the return value of `prompt`? | ||
It says undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prompt()
should not have returned undefined
. You can look up the function at MDN to find out what its return value is.
What effect does calling the `alert` function have? | ||
//RESPONSE | ||
It says undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't you see anything happened in the browser when your call alert("Hello world!")
in the browser JS console?
You should respond to all comments given by the reviewers, update your code accordingly, and then push the files you changed on your computer to Github. If you don't push the files to Github, reviewer won't be able to see the changes you made. And after you have made the necessary changes and push your changes to Github, you should add "Needs review" label (if you want the reviewer to review the changes you made). |
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.