LONDON_JAN25 | KHALIL ALI | STRUCTURING_AND_TESTING_DATA | SPRINT 2 | WEEK 5 #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjyuan
reviewed
Apr 19, 2025
| // =============> write your new code here | ||
| function capitalise(str) { | ||
| return str =`${str[0].toUpperCase()}${str.slice(1)}`; |
There was a problem hiding this comment.
Why not just return the constructed string directly? Why assign the string to a variable first?
There was a problem hiding this comment.
Can you properly indent the code in this file?
VSCode has a built-in functionality to auto-indent code.
Comment on lines
+7
to
+12
| if(hours===0){ | ||
| return `12:00 am` | ||
| } | ||
| if(hours===12){ | ||
| return `12:00 pm` | ||
| } |
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.