London | Forogh Aghaeiyarijani | Module-Structuring-and-Testing-Data | sprint1| week1

[Forogh-Aghaeiyarijani]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[SallyMcGrath]

Hi @Forogh-Aghaeiyarijani . Is there a bit more to do here? It looks like there are many more exercises in the folders.

[SallyMcGrath]

Try writing in your explanation as well as fixing the code - we are communicating about code here.

[Forogh-Aghaeiyarijani]

Hi SallyMcGrath, Thanks for reviewing my code.
Sprint-1/errors/2.js: //Computer reads code from the line by line, so we need to first define variables and then get console.

[SallyMcGrath]

The exercise asks you to update "the expression last4Digits is assigned to, in order to get the correct value"

Can you try doing this? In your code you have changed the data type to a string. Can you think why or when it might not be a good idea to change a number to a string?

[Forogh-Aghaeiyarijani]

If cardNumber were a number (not a string), this would raise a TypeError because numbers don't have a slice() method.
If cardNumber were a number, JavaScript would throw a TypeError because slice() is not a method for numbers.
Why String Conversion Might Not Always Be Ideal:
1-Loss of Numerical Context: After converting to a string, performing arithmetic operations requires converting back to a number.
2-Performance Considerations: String manipulation can be less efficient than numerical operations, especially in large-scale data processing.
3-Clarity: Maintaining a variable as a number can make the code easier to understand in contexts where numeric operations are expected. ​​