Skip to content

update eval settings image and description #25712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

update eval settings image and description #25712

wants to merge 4 commits into from

Conversation

barieom
Copy link
Contributor

@barieom barieom commented Oct 11, 2024 •
edited
Loading

What does this PR do? What is the motivation?

Merge instructions

  • Please merge after reviewing

Additional notes

@barieom barieom requested a review from a team as a code owner October 11, 2024 17:03
@github-actions github-actions bot added the Images Images are added/removed with this PR label Oct 11, 2024
@barieom barieom requested a review from tomshen October 11, 2024 17:03
tomshen
tomshen reviewed Oct 11, 2024
View reviewed changes
content/en/llm_observability/configuration/_index.md Outdated
@@ -15,7 +15,7 @@ further_reading:

## Overview

You can configure your LLM applications on the [Configuration page][1] with settings that can optimize your application's performance and security.
You can configure evaluations for each of your LLM applications in LLM Observability
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a period at the end.

also you should delete [1]: https://app.datadoghq.com/llm/config at the bottom of the file, since we're not using that link anymore

rtrieu
rtrieu requested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-request review upon addressing the feedback.

@rtrieu
Copy link
Contributor

rtrieu commented Nov 7, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 7, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-07 19:13:47 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-11-07 20:15:02 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@tomshen
Copy link

tomshen commented Nov 7, 2024

/merge -c

tomshen
tomshen requested changes Nov 7, 2024
View reviewed changes
Copy link

@tomshen tomshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshot needs to be updated to reflect the current location of the config button (which has been moved since this PR was made)

@barieom
Copy link
Contributor Author

barieom commented Nov 12, 2024 •
edited
Loading

The screenshot needs to be updated to reflect the current location of the config button (which has been moved since this PR was made)

updated

@rtrieu could you merge once Tom approves?

@tomshen
Copy link

tomshen commented Nov 13, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 13, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-13 18:51:42 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-11-13 18:51:45 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-11-13 22:51:44 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@rtrieu
Copy link
Contributor

rtrieu commented Nov 13, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 13, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-13 20:33:16 UTC ❌ MergeQueue

PR already in the queue with status waiting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomshen tomshen tomshen approved these changes

@rtrieu rtrieu rtrieu approved these changes

Assignees
No one assigned
Labels
Images Images are added/removed with this PR mergequeue-status: removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barieom @rtrieu @tomshen