-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[DSM] Add technology pages for DSM documentation #28983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
<table> | ||
<thead> | ||
<tr> | ||
<th>Language</th> | ||
<th>Library</th> | ||
<th>Minimal tracer version</th> | ||
<th>Recommended tracer version</th> | ||
</tr> | ||
</thead> | ||
<tbody> | ||
<tr> | ||
<td><a href="/data_streams/dotnet">.NET</a></td> | ||
<td><a href="https://www.nuget.org/packages/Azure.Messaging.ServiceBus">Azure.Messaging.ServiceBus</a></td> | ||
<td>2.53.0 </td> | ||
<td>2.53.0 or later </td> | ||
</tr> | ||
</tbody> | ||
</table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decided to use html table styling for these for consistency. Some of the tech tables have cells that span multiple columns (kafka's Go language has multiple libraries for ex.)
@johannbotha Not sure if there's a way to force it. I'm adding the anchor tag there but it doesn't seem to want to scroll 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work @lkretvix, much clearer than before.
Just a few notes:
- Any "Note" that prevents a mis-understanding, should be up front. For example, in
kafka.md
there is aNote
at the bottom related to kafka streams not fully supported. That should be more prominent, e.g. above the table or in any format that you find useful. - I would try to avoid repetition of supported library names, versions, and tracer versions in two places (the tech page and the lang page). I know for experience that they will go out of sync in weeks, not years. At the very least, I would extract them in importable fragments.
- In my opinion, it is not clear, from a page such as
kafka.md
, that they have to click the language name in the table's first column to proceed to per lang instructions. Should we add the language tiles all over again? This makes me question is we should remove the language tiles from the index page, but let's ignore that for a moment.
|
That'd be too much, so in this case feel free to ignore my comment. I was thinking more something like having the whole per-lang table to its own file and then maybe tabs, but we can do it once we see things get out of syncs.
By callout you mean the language name on the first column, correct? It took me a while to get it as a call to action, but not a blocker for me. I am thinking if it would be worth to replace |
Can you reach out to the docs folks. The goal of the sidenav is to easily get the users to that matrix. I bet it's something with the sticky header or needing the id tag to match the sidenav. |
There should be a way to do this without "each cell getting it's own file." We're using Hugo and the markdown rendering engine and hugo supports the use of variables. See https://gohugo.io/templates/introduction/#variables |
@lkretvix, from my PoV the only real blocker here is the sidenav issue that JJ is mentioning. All the rest is just nice to have and once the sidenav is fixed can be merged 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @lkretvix !
Would be great to schedule a swarm to add any small things we're missing now that we have a platform for tech specific things.
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
Co-authored-by: cswatt <[email protected]>
What does this PR do? What is the motivation?
https://datadoghq.atlassian.net/browse/DSMON-685
Customers can find it difficult to find what technologies are supported by DSM. In order to do this they need to go to each language and look at the tech libraries there. Let's create an Inversion where users can view the technology and find the languages/libraries that are supported
Also some cleanup on duplicated sections of content, converting to shortcodes
QA
https://docs-staging.datadoghq.com/lucas.kretvix/dsm-add-new-tech-pages/data_streams/technologies/rabbitmq/
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes