Skip to content

[DSM] Add technology pages for DSM documentation #28983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 30, 2025

Conversation

lkretvix
Copy link
Contributor

@lkretvix lkretvix commented Apr 25, 2025

What does this PR do? What is the motivation?

https://datadoghq.atlassian.net/browse/DSMON-685

Customers can find it difficult to find what technologies are supported by DSM. In order to do this they need to go to each language and look at the tech libraries there. Let's create an Inversion where users can view the technology and find the languages/libraries that are supported

Also some cleanup on duplicated sections of content, converting to shortcodes

QA

https://docs-staging.datadoghq.com/lucas.kretvix/dsm-add-new-tech-pages/data_streams/technologies/rabbitmq/

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Apr 25, 2025
Comment on lines 13 to 30
<table>
<thead>
<tr>
<th>Language</th>
<th>Library</th>
<th>Minimal tracer version</th>
<th>Recommended tracer version</th>
</tr>
</thead>
<tbody>
<tr>
<td><a href="/data_streams/dotnet">.NET</a></td>
<td><a href="https://www.nuget.org/packages/Azure.Messaging.ServiceBus">Azure.Messaging.ServiceBus</a></td>
<td>2.53.0 </td>
<td>2.53.0 or later </td>
</tr>
</tbody>
</table>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decided to use html table styling for these for consistency. Some of the tech tables have cells that span multiple columns (kafka's Go language has multiple libraries for ex.)

Copy link
Contributor

github-actions bot commented Apr 25, 2025

Preview links (active after the build_preview check completes)

New or renamed files

Renamed files

Modified Files

@lkretvix lkretvix marked this pull request as ready for review April 25, 2025 16:35
@lkretvix lkretvix requested review from a team as code owners April 25, 2025 16:35
@jhgilbert jhgilbert added the editorial review Waiting on a more in-depth review label Apr 25, 2025
@johannbotha
Copy link
Contributor

image Thanks for adding these, but it looks like it doesn't scroll to the right section. It takes you to the main page, but the setup matrix is still past the fold.

@lkretvix
Copy link
Contributor Author

Thanks for adding these, but it looks like it doesn't scroll to the right section. It takes you to the main page, but the setup matrix is still past the fold.

@johannbotha Not sure if there's a way to force it. I'm adding the anchor tag there but it doesn't seem to want to scroll 🤔

Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @lkretvix, much clearer than before.

Just a few notes:

  • Any "Note" that prevents a mis-understanding, should be up front. For example, in kafka.md there is a Note at the bottom related to kafka streams not fully supported. That should be more prominent, e.g. above the table or in any format that you find useful.
  • I would try to avoid repetition of supported library names, versions, and tracer versions in two places (the tech page and the lang page). I know for experience that they will go out of sync in weeks, not years. At the very least, I would extract them in importable fragments.
  • In my opinion, it is not clear, from a page such as kafka.md, that they have to click the language name in the table's first column to proceed to per lang instructions. Should we add the language tiles all over again? This makes me question is we should remove the language tiles from the index page, but let's ignore that for a moment.

@lkretvix
Copy link
Contributor Author

Thanks for the work @lkretvix, much clearer than before.

Just a few notes:

  • Any "Note" that prevents a mis-understanding, should be up front. For example, in kafka.md there is a Note at the bottom related to kafka streams not fully supported. That should be more prominent, e.g. above the table or in any format that you find useful.
  • I would try to avoid repetition of supported library names, versions, and tracer versions in two places (the tech page and the lang page). I know for experience that they will go out of sync in weeks, not years. At the very least, I would extract them in importable fragments.
  • In my opinion, it is not clear, from a page such as kafka.md, that they have to click the language name in the table's first column to proceed to per lang instructions. Should we add the language tiles all over again? This makes me question is we should remove the language tiles from the index page, but let's ignore that for a moment.

@labbati

  • Happy to move the Note section higher up 👍
  • The repetition is tough to get around. I can give myself a task to move them to shortcodes, but that means every version cell gets its own file. Not impossible to do, just takes time
  • We do have a callout to go to the language page to see how to set up DSM on those technology pages, do you think that's not enough?

image

@labbati
Copy link
Member

labbati commented Apr 28, 2025

  • The repetition is tough to get around. I can give myself a task to move them to shortcodes, but that means every version cell gets its own file. Not impossible to do, just takes time

That'd be too much, so in this case feel free to ignore my comment. I was thinking more something like having the whole per-lang table to its own file and then maybe tabs, but we can do it once we see things get out of syncs.

We do have a callout to go to the language page to see how to set up DSM on those technology pages, do you think that's not enough?

By callout you mean the language name on the first column, correct? It took me a while to get it as a call to action, but not a blocker for me. I am thinking if it would be worth to replace Java with Setup Java to make it more explicit, but probably worthless.

@johannbotha
Copy link
Contributor

Thanks for adding these, but it looks like it doesn't scroll to the right section. It takes you to the main page, but the setup matrix is still past the fold.

@johannbotha Not sure if there's a way to force it. I'm adding the anchor tag there but it doesn't seem to want to scroll 🤔

Can you reach out to the docs folks. The goal of the sidenav is to easily get the users to that matrix. I bet it's something with the sticky header or needing the id tag to match the sidenav.

@johannbotha
Copy link
Contributor

Thanks for the work @lkretvix, much clearer than before.
Just a few notes:

  • Any "Note" that prevents a mis-understanding, should be up front. For example, in kafka.md there is a Note at the bottom related to kafka streams not fully supported. That should be more prominent, e.g. above the table or in any format that you find useful.
  • I would try to avoid repetition of supported library names, versions, and tracer versions in two places (the tech page and the lang page). I know for experience that they will go out of sync in weeks, not years. At the very least, I would extract them in importable fragments.
  • In my opinion, it is not clear, from a page such as kafka.md, that they have to click the language name in the table's first column to proceed to per lang instructions. Should we add the language tiles all over again? This makes me question is we should remove the language tiles from the index page, but let's ignore that for a moment.

@labbati

  • Happy to move the Note section higher up 👍
  • The repetition is tough to get around. I can give myself a task to move them to shortcodes, but that means every version cell gets its own file. Not impossible to do, just takes time
  • We do have a callout to go to the language page to see how to set up DSM on those technology pages, do you think that's not enough?

image

There should be a way to do this without "each cell getting it's own file." We're using Hugo and the markdown rendering engine and hugo supports the use of variables. See https://gohugo.io/templates/introduction/#variables

@labbati
Copy link
Member

labbati commented Apr 29, 2025

@lkretvix, from my PoV the only real blocker here is the sidenav issue that JJ is mentioning. All the rest is just nice to have and once the sidenav is fixed can be merged 👍🏻

@lkretvix lkretvix requested review from labbati and johannbotha April 29, 2025 20:45
Copy link
Contributor

@johannbotha johannbotha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lkretvix !

Would be great to schedule a swarm to add any small things we're missing now that we have a platform for tech specific things.

@lkretvix
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 30, 2025

View all feedbacks in Devflow UI.

2025-04-30 14:39:23 UTC ℹ️ Start processing command /merge


2025-04-30 14:39:32 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-04-30 14:54:15 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-04-30 15:11:27 UTC ℹ️ MergeQueue: This merge request was merged

@lkretvix lkretvix removed the request for review from labbati April 30, 2025 14:59
@dd-mergequeue dd-mergequeue bot merged commit fb9c40f into master Apr 30, 2025
24 of 29 checks passed
@dd-mergequeue dd-mergequeue bot deleted the lucas.kretvix/dsm-add-new-tech-pages branch April 30, 2025 15:11
estherk15 pushed a commit that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants