Skip to content

WIP: track mitigated status better in reimport #12258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: bugfix
Choose a base branch
from

Conversation

valentijnscholten
Copy link
Member

@valentijnscholten valentijnscholten commented Apr 17, 2025

WIP alternative to #12249

possibly self.mitigate_finding should be used instead of setting the mitigation related fields manually.

@valentijnscholten valentijnscholten force-pushed the special_status_via_tracking branch from 8d80f5e to fa88629 Compare April 17, 2025 12:13
@valentijnscholten
Copy link
Member Author

The unit tests are failing because in a single reimport first an existing active inding gets mitigated but later that same existing finding gets matched against another finding in the reimport and gets reactivated again. This make the finding part of both mitigated_items and reactivated_items resulting in two import history items. this sound incorrect. But the code without the changes in this PR is also incorrect as it records the finding as reactivated while it already was active before the import.

@valentijnscholten valentijnscholten changed the title track mitigated status better in reimport WIP: track mitigated status better in reimport Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant