-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update verbose name + help text for JIRA username and password fields #12261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request suggests a potential input validation concern with increasing username and password field lengths to 2000 characters, which might require additional validation to prevent potential input abuse. 💭 Unconfirmed Findings (1)
All finding details can be found in the DryRun Security Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valentijnscholten I apologize for the flip flop here, but can this PR go against dev instead? There is already a 226 migration over there, so this one would complicate the release process a little bit
c8c1f6b
to
f90d6da
Compare
@Maffooch I made two changes, see EDIT1 and EDIT2 above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has been a recent rule to not allow changes to existing migrations any longer. Can you please make new migrations, and then base this PR against the dev branch?
83486e5
to
c364210
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
To accompany #12250 (but also good on itself)
EDIT1:Because these changes are only to textual Django fields that are not affecting the database sql schema it's safe to edit the existing migration that introduced these fields. Initially I had created a migration but it would conflict with other PRs so this is more efficient.Tested upgrade from bugfix to code with this PR included locally. It works and passes the "no db model changes check" on startup and also passes docker compose exec uwsgi bash -c "python manage.py makemigrations"EDIT2:
Turns out the
help_text
andverbose_name
were not shown on the JIRA forms as they got hidden because of redeclaring the password field in the form classes. I linked to the texts there as well.