Skip to content

fix: install proper dotnet version on CI for coverage #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix: install proper dotnet version on CI for coverage #614

merged 1 commit into from
Apr 10, 2025

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Apr 10, 2025 •
edited
Loading

Description

We were using the default dotnet 8 for coverage uploading; however, we needed dotnet 9 for the tool to work. This should correct uploading coverage on CI.

Testing

Won't know till we land and check master CI output.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team as a code owner April 10, 2025 16:58
@Justintime50 Justintime50 merged commit 772808f into master Apr 10, 2025
16 checks passed
@Justintime50 Justintime50 deleted the coverage_dotnet_version branch April 10, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranebo ranebo ranebo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Justintime50 @ranebo