Apple Ads Attribution (without IDFA) #5610
Merged
+139
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
jon/aaa-2
branch
2 times, most recently
from
eac2318 to
918b139
Compare
swansontec
approved these changes
Jun 3, 2025
ios/edge/AppDelegate.mm
Outdated
Comment on lines
11
to
12
| #import <AdServices/AdServices.h> | ||
| #import <AppTrackingTransparency/AppTrackingTransparency.h> |
There was a problem hiding this comment.
Adding a header file does nothing, unless you are using the code inside. It's basically the same as an import statement in JavaScript.
Ok, maybe some import statements have side effects, and I guess maybe that's true here too, but it's pretty weird for a C-style language. I'm guessing you can delete these.
src/util/tracking.ts
Outdated
| @@ -201,12 +202,13 @@ export function trackError( | |||
| /** | |||
| * Send a raw event to all backends. | |||
| */ | |||
|
|
|||
Jon-edge
force-pushed
the
jon/aaa-2
branch
2 times, most recently
from
2aeb7ba to
d9bf700
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: