This repository was archived by the owner on Mar 1, 2024. It is now read-only.
Downgrade ts-jest and jest to support older Node version #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehb
added a commit
that referenced
this pull request
Mar 23, 2023
* Downgrade ts-jest and jest to support older Node version (#168) * Downgrade ts-jest and jest to support older Node version * bumbed ts-jest to 27.1.5 (latest 27.x.y) * Bump lib-pixelstreamingfrontend to 0.3.0 Signed-off-by: Luke Bermingham <[email protected]> * Bump lib-pixelstreamingfrontend-ui to 0.2.0 update dep versions Signed-off-by: Luke Bermingham <[email protected]> * Bump versions in package-lock.json for ui-library * Bump ui-library to 0.2.0 and force NPM publish * Update UE version printed when Cirrus starts Signed-off-by: Luke Bermingham <[email protected]> * Bump Github release of 5.2 infra to 0.4.0 Signed-off-by: Luke Bermingham <[email protected]> * Fix: sfu player would try subscribing when sfu disconnected * Updating the Frontend Docs (#152) --------- Signed-off-by: Luke Bermingham <[email protected]> Co-authored-by: hmuurine <[email protected]> Co-authored-by: William Belcher <[email protected]> Co-authored-by: Michael Stopa <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
The script in
platform_scripts/cmd/run_local.batinstalls NodeJS version 16.4.2, which is not compatible withts-jestversion 28.0.0 or newer. f58b32c installedts-jest29.0.5, which resulted inUnsupported engineerrors if using NodeJS 16.4.2. See issue: #167The versions of all Jest packages need to be downgraded to 27.x.y series, which are compatible with NodeJS version 16.4.2.
Solution
Downgraded
ts-jestpackage to version 27.1.5, which is the latest version that supports Node 16.4.2. Also downgradedjestandjest-environment-jsdomto the latest 27 series version to fulfillts-jest27 requirements.Documentation
No changes in documentation.
Test Plan and Compatibility
Ran
npm installandnpm run testwith NodeJS 16.4.2 and verified that there were no longer complaints about NodeJS version mismatch. Verified that the unit tests worked like before with the downgraded Jest version.