Skip to content
This repository was archived by the owner on Mar 1, 2024. It is now read-only.

Fix: sfu player would try subscribing when sfu disconnected #172

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

Belchy06
Copy link
Collaborator

@Belchy06 Belchy06 commented Mar 22, 2023

Relevant components:

  • Signalling server
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

In Cirrus, when the SFU disconnects, the player representing the SFU would try and subscribe to the SFU. This is just a simple type, the player should instead unsubscribe.

Solution

Fix the type. The player now unsubscribes on SFU disconnect.

Fixes #171

Test Plan and Compatibility

Tested streaming both with and without the SFU. Checked that on SFU disconnect, the player will unsubscribe instead of subscribing.

@Belchy06 Belchy06 added the bug Something isn't working label Mar 22, 2023
@Belchy06 Belchy06 added this to the 5.2 milestone Mar 22, 2023
@Belchy06 Belchy06 self-assigned this Mar 22, 2023
@Belchy06 Belchy06 requested a review from lukehb March 22, 2023 03:20
Copy link
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukehb lukehb merged commit 3559c10 into EpicGames:master Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

[BUG] - onSFUDisconnected sfuPlayer.Subscribe()
2 participants