This repository was archived by the owner on Mar 1, 2024. It is now read-only.
Fix: sfu player would try subscribing when sfu disconnected #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
In Cirrus, when the SFU disconnects, the player representing the SFU would try and subscribe to the SFU. This is just a simple type, the player should instead unsubscribe.
Solution
Fix the type. The player now unsubscribes on SFU disconnect.
Fixes #171
Test Plan and Compatibility
Tested streaming both with and without the SFU. Checked that on SFU disconnect, the player will unsubscribe instead of subscribing.