This repository was archived by the owner on Mar 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 260
Rewriting a bunch of reconnect and disconnect handling. #419
Merged
mcottontensor
merged 4 commits into
EpicGames:master
from
mcottontensor:fix_reconnect_flow
Nov 2, 2023
Merged
Rewriting a bunch of reconnect and disconnect handling. #419
mcottontensor
merged 4 commits into
EpicGames:master
from
mcottontensor:fix_reconnect_flow
Nov 2, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehb
reviewed
Nov 1, 2023
lukehb
reviewed
Nov 1, 2023
lukehb
reviewed
Nov 1, 2023
lukehb
reviewed
Nov 1, 2023
lukehb
reviewed
Nov 1, 2023
lukehb
reviewed
Nov 1, 2023
lukehb
reviewed
Nov 1, 2023
lukehb
reviewed
Nov 1, 2023
lukehb
reviewed
Nov 1, 2023
lukehb
suggested changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments.
@MWillWallT This PR changes some loading bearing code around reconnections and disconnections. Can I get you to test the following:
Also keep in mind some of the messages displayed on the frontend change in this PR. Might be worth seeing if all the common ones are worded correctly and make sense for the scenario they show up in. |
I've gone through and tested as many re-connection configs as I can, as well as all the suggested you mentioned @lukehb |
lukehb
approved these changes
Nov 2, 2023
QA has passed, you can consider backporting to 5.2, 5.3 too with this one I think. |
mcottontensor
added a commit
that referenced
this pull request
Nov 2, 2023
Rewriting a bunch of reconnect and disconnect handling.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
In addressing #401 I noticed there was a lot of clumsiness when dealing with disconnections and reconnections. There were several situations that would lead to reconnection loops, or incorrect status reporting etc.
Solution
I have cleaned up and streamlined a bunch of the logic around when to connect and which streamers to auto subscribe to. I have also made changes to how the reporting is done on the overlay.
Fixes #401
Documentation
Test Plan and Compatibility
A lot of manual tests and the usual npm tests. Will need further QA.