Skip to content

Support flexfec, ulpfec, and any other non-video video codecs. #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

lukehb
Copy link
Contributor

@lukehb lukehb commented Aug 23, 2024

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

The current code pruned the list of supported codecs to only include h.264, vpx, av1, but this meant error correction codecs like flexfec, ulpfec, and so on were removed from the browsers sdp (even though they are supported!).

Solution

This PR does not prune any codecs, but instead puts our preferred codec at the top and then adds all the other supported codecs.

Documentation

N/A

Test Plan and Compatibility

This has been tested on my machine and @gingernaz's machine and flexfec successfully is shown in the supported codecs and WebRTC stats using this PR.

This PR makes #46 redundant.

lukehb and others added 3 commits August 1, 2024 04:16
@lukehb lukehb added bug Something isn't working auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.4 Auto backport to UE 5.4 auto-backport-to-UE5.3 Auto backport to UE 5.3 auto-backport-to-UE5.2 Auto backport to UE 5.2 auto-backport-to-UE5.5 labels Aug 23, 2024
@lukehb lukehb changed the title Support flexfec, ulpfec, red, and any other non-video video codecs. Support flexfec, ulpfec, and any other non-video video codecs. Aug 23, 2024
@lukehb lukehb mentioned this pull request Aug 23, 2024
6 tasks
@mcottontensor mcottontensor merged commit 6cadad9 into master Aug 23, 2024
13 checks passed
@mcottontensor mcottontensor deleted the flexfec branch August 23, 2024 06:07
Copy link
Contributor

💔 All backports failed

Status Branch Result
UE5.4 Cherrypick failed because the selected commit (2750778) is empty. Did you already backport this commit?
UE5.3 Cherrypick failed because the selected commit (2750778) is empty. Did you already backport this commit?
UE5.2 Backport failed because of merge conflicts

You might need to backport the following PRs to UE5.2:
- Disable fullscreen button on IPhone as fullscreen API does not work on IPhone.
- Better (?) handling of the disconnect states.
UE5.5 Cherrypick failed because the selected commit (2750778) is empty. Did you already backport this commit?

Manual backport

To create the backport manually run:

backport --pr 248

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@mcottontensor
Copy link
Collaborator

Manually cherry-picked into 5.3 and 5.4
5.5 will get merged from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.2 Auto backport to UE 5.2 auto-backport-to-UE5.3 Auto backport to UE 5.3 auto-backport-to-UE5.4 Auto backport to UE 5.4 auto-backport-to-UE5.5 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants