Support flexfec, ulpfec, and any other non-video video codecs. #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
The current code pruned the list of supported codecs to only include h.264, vpx, av1, but this meant error correction codecs like flexfec, ulpfec, and so on were removed from the browsers sdp (even though they are supported!).
Solution
This PR does not prune any codecs, but instead puts our preferred codec at the top and then adds all the other supported codecs.
Documentation
N/A
Test Plan and Compatibility
This has been tested on my machine and @gingernaz's machine and flexfec successfully is shown in the supported codecs and WebRTC stats using this PR.
This PR makes #46 redundant.