catch up #2
Merged
catch up #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that it is enabled by default on browserify builds - mv it to `./tasks/` for better discoveribility - ignore it when bundling plotly-with-meta.js bundle - 🔪 other refs to compress_attributes.js
Reason: to be reviewable from a perf standpoint.
- Set hoverMode to 'closest' where needed.
- Instead of an expandingIndex to identify the actual trace wanted, expecting a searchInfo object.
- Reason: the selection cache wasn't cleared when a user clicked the last selected point with Shift and thus a new selection started with Shift would add to the still cached selection testers from previous selection.
- Ensure click-to-select cleanly clears and starts selections although add/subtract mode on. - Ensure double click in lasso and select mode cleanly clears and restarts selections when add/subtract mode on.
- TODO: deactivated a mouseout listener in geo.js cause with it, click-to-select won't work. To be reviewed. - Include additional for choropleth that's based on geo. - One double click location in an existing choropleth test needed to change though to be on an empty area that is not a world country.
- Reason: some tests ran into async timeout issues on CI.
- Thereby fixed bug in geo base plot: set a subplot id in dragOptions so that selection cache isn't coerced each time an interaction happens.
- Ternary was the only base plot with inconsistent behavior in terms of holding the Shift key. It allowed to temporarily pan (zoom when in pan) in zoom, lasso and select drag modes.
- Updates of TODO comments are based on discussions on Github and Slack.
- Reason: isPointOrBinSelected is a potentially costly operation and thus leverage an assignment in an if condition trick to avoid executing isPointOrBinSelected unnecessarily.
- which now doesn't skip over line traces after non-line traces - update two gl2d_text_chart baseline that suffer from this bug
... where we ignore the compress_attributes.js transform
on bundling.
... before native 'webgl_contextlost' is triggered.
…Points 1852 persistent click
Enable compress attributes browserify transform by default
so that: - we don't have to worry about ordering on relayouts - subplots on non-full-circle sectors can have functioning inner radial dragboxes.
Add `polar.hole`
- like more 'recent' subplot types.
- test gl2d 'focus' canvas - test the 3 parcoords canvases!
- regl-line2d "skips" over "undefined"s, not "null"s
fix layer ordering of scatter subtypes
- as JSON.stringify(new Float32Array([1,2,3])) gives:
"{"0":1,"1":2,"2":3}"
- use Lib.simpleMap as opposed to Array.prototype.slice.call(d)
to avoid potential 'exceed stack size' errors
Ternary w/o ticks fixes
Emit 'plotly_webglcontextlost' event on WebGL context lost
Convert typed array to 'regular' arrays before sendToCloud
Fix scattergl missing lines after non-line trace
There are now 4 `<g.drag>` nodes in polar subplots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catch up