Bugcheck 165 (cannot find tip page) happens if engine crashed right after CREATE DATABASE [CORE4260]

[firebird-automations]

Submitted by: @pavel-zotov

To reproduce
start fbserver

run isql and issue
create database 'a.fdb';
kill fbserver
exit isql

start fbserver
run isql and issue
connect 'a.fdb';
you see error:

Statement failed, SQLSTATE = XX000
internal Firebird consistency check (cannot find tip page (165), file: tra.cpp line: 2369)

Commits: 37344e1 FirebirdSQL/fbt-repository@f7ebd46

[firebird-automations]

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

[firebird-automations]

Modified by: @dyemanov

reporter: Vlad Khorsun [ hvlad ] => Pavel Zotov [ tabloid ]

[firebird-automations]

Commented by: @AlexPeshkoff

Missing tip page is a first bug issued by firebird when it tries to attach to incompletely created database. Suppose 2 things will be useful:
- on startup check for minimum number of pages in database and produce better diagnostic if it's less than minimum for empty database.
- on any error during database create delete half-done database file. Certainly this will not work if server is killed to agressively.

[firebird-automations]

Commented by: @hvlad

> - on startup check for minimum number of pages in database and produce better diagnostic if it's less than minimum for empty database.
It will not work as, for example, 1st TIP page could be very far from header page

- on any error during database create delete half-done database file. Certainly this will not work if server is killed to agressively.
It will not allow to analyze reason of engine failure

We can introduse some kind of health flag at header page : set it when database file correctly closed and clear it when database file
is opened in write mode.

In any case, I think it is better to move this discussion to the fb-devel.

[firebird-automations]

Commented by: @AlexPeshkoff

No need in discussion - such flag will solve all issues.