Fixed bug #8203 : Function MAKE_DBKEY may produce random errors if used with relation name #8204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed with relation name Also, corrected handling of non-ASCII tables names.
asfernandes
reviewed
Aug 4, 2024
asfernandes
approved these changes
Aug 5, 2024
hvlad
added a commit
that referenced
this pull request
Aug 7, 2024
Fixed bug #8203 : Function MAKE_DBKEY may produce random errors if used with relation name
asfernandes
reviewed
Aug 8, 2024
| @@ -12306,7 +12306,9 @@ DmlNode* SysFuncCallNode::parse(thread_db* tdbb, MemoryPool& pool, CompilerScrat | |||
|
|
|||
| if (literal && literal->litDesc.isText()) | |||
| { | |||
| const MetaName relName = literal->getText(); | |||
| MetaName relName; | |||
| CVT2_make_metaname(&literal->litDesc, name, tdbb->getAttachment()->att_dec_status); | |||
There was a problem hiding this comment.
Must be relName, not name here.
There was a problem hiding this comment.
Thanks. I was sure I checked it :(
dyemanov
pushed a commit
that referenced
this pull request
Nov 16, 2024
Fixed bug #8203 : Function MAKE_DBKEY may produce random errors if used with relation name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, corrected handling of non-ASCII tables names.