Skip to content

Fix type for pointers operations #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

Octaviarius
Copy link
Contributor

This PR fixes type of pointer operations

While I working with RL78 MCU I caught a problem: heap allocation was putting into fault my device. After investigation the problem I found sizeof(size_t) != sizeof(void*). It can be fixed with replacement size_t in pointer arithmetic to uintptr_t via FreeRTOS.h file.

Just use heap allocation on RL78 MCU

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Octaviarius Octaviarius requested a review from a team as a code owner August 22, 2022 08:02
@Octaviarius
Copy link
Contributor Author

Sorry, I rollback changes in FreeRTOS.h because uintptr_t isn't compatible with C89

@aggarg
Copy link
Member

aggarg commented Aug 22, 2022

There are a lot of white space changes and splitting of variable declarations on multiple lines. Are those related too? If not, can we remove those please to make the PR easy to review?

@Octaviarius
Copy link
Contributor Author

Octaviarius commented Aug 22, 2022

I made aligning in some lines and split variable declarations on separated lines for making code more readable. If it's not much complicated, could it stay as is? There are not so much critical changes.

@aggarg
Copy link
Member

aggarg commented Aug 23, 2022

We have auto formatter which is anyway going to override the spacing changes. Regarding the splitting changes, would you please move them to a separate PR as those are unrelated?

@aggarg
Copy link
Member

aggarg commented Aug 23, 2022

Let me know if you'd like me to make those changes for you.

@RichardBarry
Copy link
Contributor

For consistency across all files in the library, and all the other libraries, my preference is to keep the variable declarations as they were, so not split across lines,

@Octaviarius
Copy link
Contributor Author

Octaviarius commented Aug 23, 2022 via email

@Octaviarius
Copy link
Contributor Author

I've opened new PR without indentations. #550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants