RuleMatcher for TagSubscriber, InvalidationSubscriber

[dbu]

we should allow to configure a global RuleMatcher in the tag_listener section instead of hardcoding the response codes (see TagSubscriber $response->isSuccessful).

i would only allow the match_response and the additional_cacheable_status options i guess, matching the request makes no sense for tags.

[dbu]

same about InvalidationSubscriber, we could make it configurable when to invalidate and when not.

check for ->isSuccessful() in the whole code and see if we can have a general concept for this.

[ddeboer]

Isn't this possible now with match_response and additional_cacheable_status?

[dbu]

nope, i am talking about this one: https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/blob/master/EventListener/TagSubscriber.php#L71

but this can easily be added later.

[ddeboer]

I see.

[ddeboer]

Should we separate the RuleMatcherInterface into a RequestRuleMatcherInterface and a ResponseRuleMatcherInterface?

[dbu]

good idea. we could add those 2 interfaces and make RuleMatcherInterface bring together the two. that way we would not even need to change existing code and risk breaking custom things.

[ddeboer]

That's some good BC thinking. :)