Remove inline C from bundle docs (moved to library)

[ddeboer]

Remove inline C from bundle docs, as it’s been moved to library. Fix #219.

[dbu]

travis complains that the link has a syntax error

[ddeboer]

Ah, that’s because the varnish_customttl reference wasn’t added to the lib docs until recently, and we point the bundle docs to the lib’s stable branch. Should we wait with merging this PR until we have a stable 2.0 lib, or should we already start preparing the bundle for a 2.0 and change the doc URL to point to the lib’s unstable 2.0?

[dbu]

the unstable doc of the bundle (aka 2.0) should link with the unstable doc of the library i would say. otherwise as we update, more and more things will get out of sync.

[dbu]

ah, we have not started 2.0 of the bundle. lets do that now i would say, and start the 1.3 branch for fixes until 2.0 can be released.

[ddeboer]

True, but we decided to not have separate unstable branches. So let’s link both master branches together and have the bundle master’s docs point to the lib’s master ones?

On 30 Sep 2015, at 09:22, David Buchmann [email protected] wrote:

In Resources/doc/reference/configuration/headers.rst #240 (comment):

• sub vcl_fetch {

•    if (beresp.http.X-Reverse-Proxy-TTL) {
  

•        C{
  

•            char *ttl;
  

•            ttl = VRT_GetHdr(sp, HDR_BERESP, "\024X-Reverse-Proxy-TTL:");
  

•            VRT_l_beresp_ttl(sp, atoi(ttl));
  

•        }C
  

•        unset beresp.http.X-Reverse-Proxy-TTL;
  

•    }
  

- }

-Note that there is a beresp.ttl field in VCL but unfortunately it can only
-be set to absolute values and not dynamically. Thus we have to revert to a C
-code fragment.
+you need to extend your varnish vcl_fetch configuration. Please refer to
+the :ref:FOSHttpCache library’s docs <foshttpcache:varnish_customttl>
the unstable doc of the bundle (aka 2.0) should link with the unstable doc of the library i would say. otherwise as we update, more and more things will get out of sync.
—
Reply to this email directly or view it on GitHub https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/240/files#r40764858.

[dbu]

yes, lets prepare it like this in #235 and once that is mergable the unstable doc will be 2.0

[dbu]

right, forgot this side of the story.

[dbu]

hm, this is essentially a duplicate of #235 - can you improve the documentation there and we remove this pull request? when trying to actually use the code, i found some issues as explained in #235

[ddeboer]

Agreed, let’s continue this in #235.