added remove method for Issues #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radutopala
reviewed
Oct 3, 2016
| @@ -58,6 +58,16 @@ public function update($project_id, $issue_id, array $params) | |||
| * @param int $issue_id | |||
| * @return mixed | |||
| */ | |||
| public function remove($project_id, $issue_id) | |||
There was a problem hiding this comment.
@brammeleman let's pls use delete on the method name, to keep the API's naming: https://docs.gitlab.com/ce/api/issues.html#delete-an-issue.
There was a problem hiding this comment.
Mmmh... I'm confused: the gitlab API just tells to do a http delete on an issue id, which is like any other object in gitlab.
There was a problem hiding this comment.
All other objects use remove:
~/src/php-gitlab-api/lib/Gitlab/Api $ grep function * | egrep 'remove|delete'
AbstractApi.php: protected function delete($path, array $parameters = array(), $requestHeaders = array())
Groups.php: public function remove($group_id)
Groups.php: public function removeMember($group_id, $user_id)
Issues.php: public function remove($project_id, $issue_id)
Projects.php: public function remove($project_id)
Projects.php: public function removeMember($project_id, $user_id)
Projects.php: public function removeHook($project_id, $hook_id)
Projects.php: public function removeKey($project_id, $key_id)
Projects.php: public function removeLabel($project_id, $name)
Projects.php: public function removeForkRelation($project_id)
Projects.php: public function removeService($project_id, $service_name)
Projects.php: public function removeVariable($project_id, $key)
Repositories.php: public function deleteBranch($project_id, $branch_name)
Repositories.php: public function deleteFile($project_id, $file_path, $branch_name, $commit_message)
Snippets.php: public function remove($project_id, $snippet_id)
SystemHooks.php: public function remove($id)
Users.php: public function remove($id)
Users.php: public function removeKey($id)
Users.php: public function removeUserKey($user_id, $key_id)There was a problem hiding this comment.
Well.. there are 2 there :) .. we should rename the Repositories ones..
quentin-st
added a commit
to quentin-st/php-gitlab-api
that referenced
this pull request
Oct 3, 2016
radutopala
pushed a commit
that referenced
this pull request
Oct 3, 2016
* Add ability to delete an issue comment * Rename deleteComment to removeComment according to #149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.