-
-
Notifications
You must be signed in to change notification settings - Fork 456
added method to get artifacts file #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you remove the .idea from the gitignore please and fix the CS on the line I've commented on above. Hint: Add .idea to your global ignore file. |
->will($this->returnValue($expectedArray)) | ||
; | ||
|
||
$this->assertEquals($expectedArray,$api->buildArtifacts(1,2)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space between comma and 2
.gitignore
Outdated
composer.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
@Seretos I think @m4tthumphrey is waiting for you to remove the addition of "composer.lock" in the Thanks by the way to both of you for your great work! |
@Seretos can't seem to find the API endpoints for |
@radutopala You don't want to use the Builds API you are referring to (https://docs.gitlab.com/ce/api/ci/builds.html). This is reserved to be used only by the runners. You really want to use the Jobs API: https://docs.gitlab.com/ce/api/jobs.html#download-the-artifacts-file By the way, I tested this PR in both Gitlab 8 and Gitlab 9 and it works. |
I'm closing this PR as it use runners reserved API and it's superseded by #196. Thank you anyway! |
Hihi, thanks for this api...
i have added a little method to get the artifacts zip file from a single build