Skip to content

Allowing different archive format types #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2017

Conversation

violuke
Copy link
Contributor

@violuke violuke commented May 5, 2017

Allowing different archive format types. Backwards compatible as default is tar.gz which is what was the default before.
Correcting incorrect comment about "content" key in array too.

Correcting incorrect comment about "content" key in array too.
@violuke
Copy link
Contributor Author

violuke commented May 5, 2017

Note, I don't believe that the failed test here is related to my change:

There was 1 failure:

1) Gitlab\Tests\Api\ProjectsTest::shouldGetOwnedProjects
Expectation failed for method name is equal to <string:get> when invoked 1 time(s)
Parameter 0 for invocation Gitlab\Api\AbstractApi::get('projects?owned=1', Array (...), Array ()) does not match expected value.
Failed asserting that two strings are equal.

--- Expected
+++ Actual
@@ @@
-'projects/owned'
+'projects?owned=1'

/home/travis/build/m4tthumphrey/php-gitlab-api/lib/Gitlab/Api/Projects.php:56
/home/travis/build/m4tthumphrey/php-gitlab-api/test/Gitlab/Tests/Api/ProjectsTest.php:70

@m4tthumphrey m4tthumphrey merged commit 51242d8 into GitLabPHP:master Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants