[10.0] Switch to PSR-17 and PSR-18 #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
acrobat
added a commit
to KnpLabs/php-github-api
that referenced
this pull request
Jun 28, 2020
…inimum version to ^2.0 (GrahamCampbell) This PR was merged into the 2.15.x-dev branch. Discussion ---------- `php-http/client-implementation` is deprecated and Guzzle 7 doesn't implement it, so this will be a blocker for anyone wanting to upgrade from Guzzle 6 to 7 and use this package at the same time. --- Related: GitLabPHP/Client#511, BitbucketPHP/Client#39, php-http/discovery#175. Commits ------- ec31be1 Switch to PSR18 client impl
GrahamCampbell
changed the title
|
Is this ready for merging? |
|
@m1guelpf Yes, however before merging, I'd recommend you branch off a |
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP Plug 1 is deprecated and HTTP Plug 2 recommends only using PSR-17 and PSR-18, rather than the old interfaces. Moreover, Guzzle 7 only implements the new interfaces, so this will be a blocker for anyone wanting to upgrade from Guzzle 6 to 7 and use this package at the same time. I've also fixed a bunch of static analysis errors and added support for cache plugins (just like in KnpLabs/php-github-api).
Note that these changes require bumping the next version of this package to 10.0.0, which is fine. Upgrading shouldn't be hard for people. ;)
Related: KnpLabs/php-github-api#885, BitbucketPHP/Client#39, BitbucketPHP/Client#53, php-http/discovery#175.