Bump dep reqwest from 0.11.12 to 0.12.0 #1327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That seemed…easier than I thought it would be, awesome! I will merge once CI is green and believe this isn't a breaking change as the |
|
I am taking a look at the test failures now, hoping to push a fix soon. |
That way we assure that the version will always be the correct one within the workspace, which is required for proper function.
In short, reqwest sends a `content-length: 0` header in GET requests for a reason maybe related to this issue: seanmonstar/reqwest#1971 For now, let's ignore Content-Length header lines.
That way, versions can't diverge.
|
Thanks! I would never know how to fix the tests by myself 😂 |
|
@Byron Can we publish a new patch release please? |
|
Alright, |
|
Thanks! |
Byron
added a commit
that referenced
this pull request
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reqwest 0.12.0 has released, which finally switched to hyper v1
https://github.com/seanmonstar/reqwest/releases/tag/v0.12.0